Skip to content

IEI-6448: Remove underscore from init path #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohitsingh1420 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IEI-6448: Remove underscore from init path #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,4 @@ type RequestMeta = {
};
type RequestPacket = Record<string, any> & RequestMeta;
type Service = 'assess' | 'author' | 'authoraide' | 'items' | 'reports' | 'questions' | 'data';
type Action = 'get' | 'set' | 'update';
type Action = 'get' | 'set' | 'update' | 'post';
13 changes: 6 additions & 7 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
*
*/

const _ = require('underscore');
const crypto = require('crypto');
const moment = require('moment');
const os = require('os');
Expand Down Expand Up @@ -44,11 +43,11 @@ const moduleInfo = require('./package.json');
*/

/**
* @typedef {'assess' | 'author' | 'items' | 'reports' | 'questions' | 'data'} Service
* @typedef {'assess' | 'author' | 'authoraide' | 'items' | 'reports' | 'questions' | 'data'} Service
*/

/**
* @typedef {'get' | 'set' | 'update'} Action
* @typedef {'get' | 'set' | 'update' | 'post'} Action
*/

/**
Expand All @@ -58,7 +57,7 @@ const moduleInfo = require('./package.json');
* @returns {RequestPacket}
*/
function convertRequestPacketToObject(requestPacket) {
if (_.isString(requestPacket)) {
if (typeof requestPacket === 'string') {
return JSON.parse(requestPacket);
} else {
return requestPacket;
Expand Down Expand Up @@ -239,7 +238,7 @@ LearnositySDK.prototype.init = function (
}

// Automatically populate the user_id of the security packet.
if (_.contains(['author', 'items', 'reports', 'authoraide'], service)) {
if (['author', 'items', 'reports', 'authoraide'].includes(service)) {
// The Events API requires a user_id, so we make sure it's a part
// of the security packet as we share the signature in some cases
if (!securityPacket.user_id && requestObject && requestObject.user_id) {
Expand Down Expand Up @@ -270,13 +269,13 @@ LearnositySDK.prototype.init = function (
// Questions API Requests don't need `domain`
delete securityPacket.domain;

output = _.extend(securityPacket, requestObject);
output = Object.assign(securityPacket, requestObject);
} else if (service === 'assess') {
output = requestObject;
} else {
output = {
'security': securityPacket,
'request': _.isString(requestPacket) ? requestString : requestObject
'request': typeof requestPacket === 'string' ? requestString : requestObject
};
}

Expand Down
Loading