Skip to content

build: Cleanup build scripts and watchers#2236

Merged
rkaraivanov merged 2 commits into
masterfrom
rkaraivanov/build-scripts-cleanup
May 28, 2026
Merged

build: Cleanup build scripts and watchers#2236
rkaraivanov merged 2 commits into
masterfrom
rkaraivanov/build-scripts-cleanup

Conversation

@rkaraivanov
Copy link
Copy Markdown
Member

Description

  • Dropped node-watch dependency and replaced it with native fs.watch
  • Updated build-styles.mjs to use a single buildAll function instead of separate buildThemes and buildComponents functions
  • Improved logging in stories-watcher.js to include timestamps and better error handling
  • Updated dev dependencies in package.json

- Dropped node-watch dependency and replaced it with native fs.watch
- Updated build-styles.mjs to use a single buildAll function instead of separate buildThemes and buildComponents functions
- Improved logging in stories-watcher.js to include timestamps and better error handling
- Updated dev dependencies in package.json
Copilot AI review requested due to automatic review settings May 28, 2026 17:06
@rkaraivanov rkaraivanov added dependencies Pull requests that update a dependency file Build/CI labels May 28, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR streamlines the local/build tooling by removing the node-watch dependency in favor of Node’s native fs.watch, consolidating Sass build steps behind a single buildAll() entrypoint, and refining story metadata generation/logging.

Changes:

  • Replace node-watch usage with native fs.watch in the SCSS and stories watchers.
  • Add buildAll() to unify theme + component Sass generation and update build scripts to use it.
  • Refactor build-stories.mjs for more robust manifest parsing/type handling and reduce unnecessary file writes; bump several dev dependencies.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
stories/date-time-input.stories.ts Updates Storybook args/argTypes ordering and typing for DateTimeInput.
scripts/styles-watcher.mjs Switches SCSS watcher from node-watch to fs.watch and improves log messages.
scripts/stories-watcher.js Switches metadata watcher to fs.watch and updates logging/error handling.
scripts/sass.mjs Introduces buildAll() and refactors theme/component build functions.
scripts/build.mjs Uses buildAll(true) during publish builds instead of separate theme/component builds.
scripts/build-styles.mjs Uses buildAll() for local style generation.
scripts/build-stories.mjs Refactors story metadata generation (typing, parsing, write strategy, error handling).
package.json Updates dev dependency versions and removes node-watch.
package-lock.json Locks updated dependency graph reflecting package.json changes.

Comment thread scripts/styles-watcher.mjs Outdated
Comment thread scripts/styles-watcher.mjs
Comment thread scripts/stories-watcher.js Outdated
Comment thread scripts/sass.mjs Outdated
Comment thread scripts/sass.mjs Outdated
Comment thread scripts/sass.mjs Outdated
@rkaraivanov rkaraivanov merged commit 3318505 into master May 28, 2026
7 checks passed
@rkaraivanov rkaraivanov deleted the rkaraivanov/build-scripts-cleanup branch May 28, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build/CI dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants