fix(for-of): guard resize observer against non-element nodes - 22.0.x - #17528
Open
viktorkombov wants to merge 1 commit into
Open
fix(for-of): guard resize observer against non-element nodes - 22.0.x#17528viktorkombov wants to merge 1 commit into
viktorkombov wants to merge 1 commit into
Conversation
viktorkombov
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a virtualization teardown bug in the IgxForOfDirective/IgxGridForOfDirective ResizeObserver integration where observe()/unobserve() could be invoked with a non-Element (e.g., null from a comment-anchor lookup), causing a TypeError and leaving virtualization in a partially torn-down state.
Changes:
- Introduces a shared helper (
getViewObservedNode) to safely resolve anElementto observe/unobserve (or returnnullwhen none exists). - Guards
ResizeObserver.observe()/unobserve()calls to skip when no validElementis resolvable. - Adds unit tests covering comment-rooted views and “no element available” scenarios, including ensuring
unobserveis not called when resolution returnsnull.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.ts | Adds a safe view→Element resolver and guards observer calls to prevent ResizeObserver from receiving non-elements. |
| projects/igniteui-angular/directives/src/directives/for-of/for_of.directive.spec.ts | Adds unit tests validating observed-node resolution and ensuring unobserve is skipped when no element exists. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| */ | ||
| protected getViewObservedNode(view: EmbeddedViewRef<any> | null | undefined): Element | null { | ||
| const rootNodes = view?.rootNodes ?? []; | ||
| const elementNode = rootNodes.find(node=> node?.nodeType === Node.ELEMENT_NODE); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17482
Description
removeLastElem()could callResizeObserver.unobserve()withnulland throw, which left the virtualization half torn down. Same unguarded lookup was used on theobserve()side, so both now go through one helper that returnsnullwhen there's no element, and the calls are skipped in that case.Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)