fix(esf): Handle remote data with ESF and remote filtering - 21.2.x#17343
Open
mddragnev wants to merge 3 commits into
Open
fix(esf): Handle remote data with ESF and remote filtering - 21.2.x#17343mddragnev wants to merge 3 commits into
mddragnev wants to merge 3 commits into
Conversation
mddragnev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an Excel Style Filtering (ESF) remote-data scenario where selected string values could be dropped when the grid only holds a current “chunk” of data, by avoiding the case-preservation remapping step for remote virtualization while keeping existing local-data behavior intact.
Changes:
- Updated ESF
applyFilter()string handling to skip mapping selected values againstgrid.datawhen the grid is remote (verticalScrollContainer.isRemote), preserving the full selected set. - Added a dedicated “remote chunk” grid sample component to simulate remote virtualization with
uniqueColumnValuesStrategy. - Added a unit test asserting that selected values from the full remote set are preserved even when the grid’s current data is chunked.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
projects/igniteui-angular/test-utils/grid-samples.spec.ts |
Adds a remote-chunk grid sample component used by the new regression test. |
projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts |
Registers the new sample and adds a regression test for the remote + ESF + unique values strategy scenario. |
projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-search.component.ts |
Adjusts ESF string in filter value derivation to preserve selected values for remote virtualization. |
Comment on lines
+7090
to
+7093
| const uncheckLabel = 'Alpha'; | ||
| const uncheckIndex = labelElements.findIndex(el => el.innerText === uncheckLabel); | ||
| expect(uncheckIndex).toBeGreaterThan(0); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17283
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)