fix(esf): Handle remote data with ESF and remote filtering#17342
Open
mddragnev wants to merge 2 commits into
Open
fix(esf): Handle remote data with ESF and remote filtering#17342mddragnev wants to merge 2 commits into
mddragnev wants to merge 2 commits into
Conversation
mddragnev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an Excel Style Filtering (ESF) edge case in the grid where, under remote/chunked data scenarios with uniqueColumnValuesStrategy + case-insensitive string filtering, selected values can be incorrectly reduced to only those present in the currently loaded grid data.
Changes:
- Adjusts ESF apply-filter logic to avoid deriving selected string values from the current
grid.datawhen the grid is considered “remote”. - Adds a new remote/chunked-data test component to reproduce the scenario.
- Adds a regression test validating selected values are preserved even when the grid holds only a subset of the full remote dataset.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
projects/igniteui-angular/test-utils/grid-samples.spec.ts |
Adds a sample component simulating chunked/remote data with uniqueColumnValuesStrategy. |
projects/igniteui-angular/grids/grid/src/grid-filtering-ui.spec.ts |
Registers the new sample component and adds a regression test for ESF selected-values preservation. |
projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-search.component.ts |
Updates ESF filter application logic to skip case-preserving remapping against grid.data for remote data; introduces isRemoteData(). |
Comment on lines
+901
to
+903
| private isRemoteData(): boolean { | ||
| return this.esf.grid.verticalScrollContainer.isRemote; | ||
| } |
Comment on lines
+7090
to
+7093
| const uncheckLabel = 'Alpha'; | ||
| const uncheckIndex = labelElements.findIndex(el => el.innerText === uncheckLabel); | ||
| expect(uncheckIndex).toBeGreaterThan(0); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17283
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)