fix(tree-grid): correctly process esf when tree grid grouping is enabled - 21.2.x#17341
Open
mddragnev wants to merge 3 commits into
Open
fix(tree-grid): correctly process esf when tree grid grouping is enabled - 21.2.x#17341mddragnev wants to merge 3 commits into
mddragnev wants to merge 3 commits into
Conversation
mddragnev
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Tree Grid Excel-Style Filtering (ESF) behavior when Tree Grid grouping is applied (closes #17293), ensuring selected ESF items are processed correctly instead of producing an empty grid.
Changes:
- Adjusts ESF string-value processing to avoid the case-normalization path when the Tree Grid data is grouped (grouping pipe output).
- Adds Tree Grid grouping + ESF regression tests for (a) selecting 3+ items and (b) preserving checked items after reopen.
- Enables filtering on the Tree Grid grouping test component columns to allow ESF interaction.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| projects/igniteui-angular/test-utils/tree-grid-components.spec.ts | Makes columns filterable in the Tree Grid grouping test component to support ESF tests. |
| projects/igniteui-angular/grids/tree-grid/src/tree-grid-grouping.spec.ts | Adds ESF + grouping regression tests (3+ selections, preserve checked state). |
| projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-search.component.ts | Skips the ignore-case “value normalization” path for grouped Tree Grid data; adds grouped detection helper. |
Comment on lines
+341
to
+343
| const uncheckedItem = checkboxes.splice(2, 1)[0]; | ||
| expect(uncheckedItem.checked).toBeFalse(); | ||
| checkboxes.forEach(c => expect(c.checked).toBeTrue()); |
Comment on lines
31
to
+32
| let NEXT_ID = 0; | ||
| const TREE_GRID_GROUPING_HIDDEN_FIELD = '_Igx_Hidden_Data_'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17293
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)