fix(tree-grid): correctly process esf when tree grid grouping is enabled#17338
Open
mddragnev wants to merge 3 commits into
Open
fix(tree-grid): correctly process esf when tree grid grouping is enabled#17338mddragnev wants to merge 3 commits into
mddragnev wants to merge 3 commits into
Conversation
mddragnev
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a TreeGrid regression where Excel Style Filtering (ESF) behaves incorrectly when TreeGrid grouping (via the grouping pipe) is enabled, causing checked items to be lost and/or the grid to become empty (Issue #17293).
Changes:
- Adjust ESF string filtering logic to avoid the ignore-case value remapping path when the TreeGrid data contains grouping “synthetic” records.
- Add TreeGrid grouping + ESF regression tests that cover selecting 3+ items and preserving checked items after reopening ESF.
- Update the TreeGrid grouping test component so columns are filterable for ESF interactions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
projects/igniteui-angular/test-utils/tree-grid-components.spec.ts |
Enables filtering on columns in the TreeGrid grouping test component used by the new regression tests. |
projects/igniteui-angular/grids/tree-grid/src/tree-grid-grouping.spec.ts |
Adds regression tests for ESF + grouping and wires GridFunctions usage. |
projects/igniteui-angular/grids/core/src/filtering/excel-style/excel-style-search.component.ts |
Adds TreeGrid-grouping detection to avoid the problematic ignore-case mapping path for grouped TreeGrid data. |
Comment on lines
8
to
+9
| import { DefaultSortingStrategy } from 'igniteui-angular/core'; | ||
| import { GridFunctions } from 'igniteui-angular/test-utils/grid-functions.spec'; |
Comment on lines
+301
to
+304
| it('should handle excel style filtering when grouping is applied and 3 or more items are selected', fakeAsync(() => { | ||
| treeGrid.filterMode = "excelStyleFilter"; | ||
| treeGrid.allowFiltering = true; | ||
| treeGrid.expansionDepth = Infinity; |
Comment on lines
+324
to
+327
| it('should handle excel style filtering when grouping is applied and preserve all checked esf items', fakeAsync(() => { | ||
| treeGrid.filterMode = "excelStyleFilter"; | ||
| treeGrid.allowFiltering = true; | ||
| treeGrid.expansionDepth = Infinity; |
Comment on lines
+902
to
+908
| private isTreeGridWithGroupBy(): boolean { | ||
| if (this.esf.grid.type !== 'tree') { | ||
| return false; | ||
| } | ||
| const data = this.esf.grid.data; | ||
| return Array.isArray(data) && data.some(item => item && typeof item === 'object' && TREE_GRID_GROUPING_HIDDEN_FIELD in item); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17293
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)