fix(grid): fix out of bounds row index when navigating down from last layout row - master #16755
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMinchev64
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where navigating down from the last layout row in a multi-row layout grid returns an out-of-bounds row index. The fix adds a boundary check to ensure navigation stays within valid data bounds.
Changes:
- Added boundary validation in the vertical navigation logic to prevent out-of-bounds row indices
- Added comprehensive test coverage for the edge case of navigating down from the last layout row
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/grids/core/src/grid-mrl-navigation.service.ts | Added boundary check to prevent out-of-bounds row index when navigating down from last layout row |
| projects/igniteui-angular/grids/grid/src/grid-mrl-keyboard-nav.spec.ts | Added test case to verify the fix for out-of-bounds navigation |
projects/igniteui-angular/grids/core/src/grid-mrl-navigation.service.ts
Outdated
Show resolved
Hide resolved
| }); | ||
|
|
||
| it('should not return an out of bounds row index when navigating down from the last layout row', () => { | ||
| fix.componentInstance.data = SampleTestData.contactInfoDataFull().slice(0, 10); |
There was a problem hiding this comment.
The magic number 10 for the data slice limit is unexplained. Consider extracting it as a named constant (e.g., const TEST_DATA_SIZE = 10;) to clarify why this specific number of records is needed for the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16644
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)