Skip to content

Breaking changes in modernize code #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jan-Schuppik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Breaking changes in modernize code #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Events.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
use Evenement\EventEmitterTrait;
use InvalidArgumentException;

trait Events

Check failure on line 8 in src/Events.php

View workflow job for this annotation

GitHub Actions / PHP / Static analysis (8.3) / PHPStan 8.3 

Trait ipl\Stdlib\Events is used zero times and is not analysed.

Check failure on line 8 in src/Events.php

View workflow job for this annotation

GitHub Actions / PHP / Static analysis (8.5) / PHPStan 8.5 

Trait ipl\Stdlib\Events is used zero times and is not analysed.

Check failure on line 8 in src/Events.php

View workflow job for this annotation

GitHub Actions / PHP / Static analysis (8.4) / PHPStan 8.4 

Trait ipl\Stdlib\Events is used zero times and is not analysed.

Check failure on line 8 in src/Events.php

View workflow job for this annotation

GitHub Actions / PHP / Static analysis (8.2) / PHPStan 8.2 

Trait ipl\Stdlib\Events is used zero times and is not analysed.
{
use EventEmitterTrait {
EventEmitterTrait::on as private evenementUnvalidatedOn;
Expand Down Expand Up @@ -50,7 +50,7 @@
* @param string $event
* @return bool
*/
public function isValidEvent($event)
public function isValidEvent(string $event): bool
{
return true;
}
Expand Down
Loading