Ensure forward compatibility with ipl-orm by adding return types#263
Merged
Ensure forward compatibility with ipl-orm by adding return types#263
ipl-orm by adding return types#263Conversation
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
d04c966 to
bb53909
Compare
sukhwinder33445
previously approved these changes
Mar 5, 2026
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
bb53909 to
2117b1f
Compare
…ndition()` Add a return type and a missing return statement to ensure forward-compatibility with ipl-orm.
Add the static return type to ensure compatibility with ipl-orm.
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
2117b1f to
3414d34
Compare
Contributor
sukhwinder33445
left a comment
sukhwinder33445
left a comment
There was a problem hiding this comment.
Looks good. I will approve it after testing the UI.
17 tasks
sukhwinder33445
approved these changes
Mar 17, 2026
lippserd
changed the title
ipl-orm by adding return types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add explicit return types to
ipl-orm-derived methods to prepare for stricttyping. These additions are safe, as they only annotate existing methods that
previously lacked return type declarations.
refs Icinga/ipl-orm#158