Skip to content

Feature: Adds support for MSSQL shared memory feature, by not using a port for the connection string by using 0 or lower as port number #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LordHepipud wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Feature: Adds support for MSSQL shared memory feature, by not using a port for the connection string by using 0 or lower as port number #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions doc/100-General/10-Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic

[Issues and PRs](https://github.com/Icinga/icinga-powershell-framework/milestone/44)

### Enhancements

* [#865](https://github.com/Icinga/icinga-powershell-framework/pull/865) Adds support for MSSQL shared memory feature, by not using a port for the connection string by using 0 or lower as port number

### Bugfixes

* [#877](https://github.com/Icinga/icinga-powershell-framework/pull/877) Fixes threshold comparison while using `%`-Values, which caused falsely report of `Warning` threshold being larger than `Critical` threshold
Expand Down
8 changes: 7 additions & 1 deletion lib/mssql/Open-IcingaMSSQLConnection.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,13 @@ function Open-IcingaMSSQLConnection()

try {
$SqlConnection = New-Object System.Data.SqlClient.SqlConnection;
$SqlConnection.ConnectionString = "Server=$Address,$Port;";

# Only add the port if it is above 0. Otherwise the fall back to the Shared Memory feature of MSSQL
if ($Port -le 0) {
$SqlConnection.ConnectionString = "Server=$Address;";
} else {
$SqlConnection.ConnectionString = "Server=$Address,$Port;";
}

if ([string]::IsNullOrEmpty($SqlDatabase) -eq $FALSE) {
$SqlConnection.ConnectionString += "Database=$SqlDatabase;";
Expand Down