refactor: reduce filter param duplication#19
Open
AlexanderNZ wants to merge 1 commit intoIcePanel:mainfrom
Open
refactor: reduce filter param duplication#19AlexanderNZ wants to merge 1 commit intoIcePanel:mainfrom
AlexanderNZ wants to merge 1 commit intoIcePanel:mainfrom
Conversation
The filter-to-URLSearchParams conversion logic was duplicated 4 times across getCatalogTechnologies, getOrganizationTechnologies, getModelObjects, and getModelConnections. This extracts a buildFilterParams helper function that handles: - Array values - Null values - Labels objects - Simple string/boolean values
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here’s a small cleanup I made so the filter query logic lives in one place.
What I changed
Why I did it
Test plan
Recommended merge order