Skip to content

Sync package-lock file with engine update, restore node 18+ support by removing terminal-link, update README#146

Merged
IanVS merged 3 commits intoIanVS:mainfrom
brokentone:chore/kenton/sync-package-lock
Oct 22, 2025
Merged

Sync package-lock file with engine update, restore node 18+ support by removing terminal-link, update README#146
IanVS merged 3 commits intoIanVS:mainfrom
brokentone:chore/kenton/sync-package-lock

Conversation

@brokentone
Copy link
Copy Markdown
Contributor

@brokentone brokentone commented Oct 16, 2025

A divergence was introduced here between the package file and the package lock file: #145 This PR syncs the package-lock.json file back with the new project expectations.

Additionally, to fix another engine inconsistency, we're removing terminal-link which at it's current version has a higher engine expectation than this project and it seems better not to depend on an "old" package.

Finally, I bumped the screenshot and some details in the README given the current state of the project

@IanVS
Copy link
Copy Markdown
Owner

IanVS commented Oct 16, 2025

I'm glad you brought this up. I'm surprised that npm ci in the CI job of that PR didn't flag the failure. So I went to look, and unfortunately it seems like sure enough it didn't block the installation (https://github.com/IanVS/eslint-nibble/actions/runs/18406068966/job/52446178330?pr=145) It seems I just misunderstood what npm ci would fail on, and this is expected: npm/cli#7464.

Worse still, we accidentally introduced a new dependency that requires node 20+ (https://github.com/sindresorhus/terminal-link/releases/tag/v5.0.0).

I think we need to downgrade that dependency to 4.0.0 so that we can maintain node.js 18+ support. Would you be willing to do that, @brokentone?

@brokentone
Copy link
Copy Markdown
Contributor Author

@IanVS oof -- sorry about that. Happy to take it on, maybe I'll just remove the package? I believe that terminal linking functionality has extremely limited support anyway (verses colors which have significant support)

@IanVS
Copy link
Copy Markdown
Owner

IanVS commented Oct 16, 2025

Sure, that would be fine too, I'll leave it up to you.

I also realized we should probably update the screenshot(s?) in the README.

@brokentone brokentone changed the title Sync package-lock file with engine update Sync package-lock file with engine update, restore node 18+ support by removing terminal-link, update README Oct 21, 2025
@brokentone
Copy link
Copy Markdown
Contributor Author

@IanVS Removed the package, tests still pass, also updated the README

@IanVS
Copy link
Copy Markdown
Owner

IanVS commented Oct 22, 2025

Thanks!

@IanVS IanVS merged commit 5748c90 into IanVS:main Oct 22, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants