Sync package-lock file with engine update, restore node 18+ support by removing terminal-link, update README#146
Conversation
|
I'm glad you brought this up. I'm surprised that Worse still, we accidentally introduced a new dependency that requires node 20+ (https://github.com/sindresorhus/terminal-link/releases/tag/v5.0.0). I think we need to downgrade that dependency to 4.0.0 so that we can maintain node.js 18+ support. Would you be willing to do that, @brokentone? |
|
@IanVS oof -- sorry about that. Happy to take it on, maybe I'll just remove the package? I believe that terminal linking functionality has extremely limited support anyway (verses colors which have significant support) |
|
Sure, that would be fine too, I'll leave it up to you. I also realized we should probably update the screenshot(s?) in the README. |
|
@IanVS Removed the package, tests still pass, also updated the README |
|
Thanks! |
A divergence was introduced here between the package file and the package lock file: #145 This PR syncs the package-lock.json file back with the new project expectations.
Additionally, to fix another engine inconsistency, we're removing
terminal-linkwhich at it's current version has a higher engine expectation than this project and it seems better not to depend on an "old" package.Finally, I bumped the screenshot and some details in the README given the current state of the project