Skip to content

IULRDC-210 DataCORE: more/less vs autolink issue#234

Open
rdlebeau wants to merge 1 commit into
mainfrom
IULRDC-210_DataCORE_more-less_vs_autolink
Open

IULRDC-210 DataCORE: more/less vs autolink issue#234
rdlebeau wants to merge 1 commit into
mainfrom
IULRDC-210_DataCORE_more-less_vs_autolink

Conversation

@rdlebeau
Copy link
Copy Markdown
Contributor

@rdlebeau rdlebeau commented May 15, 2026

  • javaScript and CSS updates
  • The number of characters shown before the 'more' link will now stick to 300 characters instead of expanding to include any links or greater than signs in the text

@rdlebeau rdlebeau requested a review from aploshay May 15, 2026 21:45
@rdlebeau rdlebeau force-pushed the IULRDC-210_DataCORE_more-less_vs_autolink branch from 80bfd31 to 4daa392 Compare May 18, 2026 15:28
@aploshay
Copy link
Copy Markdown
Contributor

Testing locally, I find this fixes a case currently broken on main, where the link starts and ends after the 300 character more/less threshold:

Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus in magna ullamcorper, tempus nibhxx
quis, bibendum erat. Praesent vestibulum libero interdum, feugiat sapien in, rhoncus ex. Aliquamxxxx
eleifend, erat ut fermentum blandit, elit orci fermentum quam, finibus dignissim tellus elit vitae 
velit. Nulla turpis duis. https://localhost:3000/concern/data_sets/000000000/edit?locale=en
vitae velit. Nulla turpis duis.

but badly breaks other cases currently working on main:

  • where the link text starts before 300, ends after 300:
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus in magna ullamcorper, tempus
nibhxx https://localhost:3000/concern/data_sets/000000000/edit?locale=en vitae velit. Nulla
turpis duis. quis, bibendum erat. Praesent vestibulum libero interdum, feugiat sapien in, rhoncus
ex. Aliquamxxxx eleifend, erat ut fermentum blandit, elit orci fermentum quam, finibus dignissim
tellus elit vitae velit. Nulla turpis duis.
  • where the link text starts before 300, ends before 300:
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Vivamus in magna ullamcorper, tempus nibhxx
https://localhost:3000/concern/data_sets/000000000/edit?locale=en vitae velit. Nulla turpis duis.
quis, bibendum erat. Praesent vestibulum libero interdum, feugiat sapien in, rhoncus ex. Aliquamxxxx
eleifend, erat ut fermentum blandit, elit orci fermentum quam, finibus dignissim tellus elit vitae
velit. Nulla turpis duis.

@rdlebeau rdlebeau force-pushed the IULRDC-210_DataCORE_more-less_vs_autolink branch from 4daa392 to a25fba2 Compare May 19, 2026 13:51
@rdlebeau
Copy link
Copy Markdown
Contributor Author

I've incorporated the changes from the "revise javascript: search backwards for start tag" commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants