Add DAS240 IOC#955
Conversation
| $(APPNAME)_DBD += drvAsynSerialPort.dbd | ||
| $(APPNAME)_DBD += drvAsynIPPort.dbd | ||
| $(APPNAME)_DBD += luaSupport.dbd | ||
| $(APPNAME)_DBD += stream.dbd |
There was a problem hiding this comment.
does this actually use stream device?
There was a problem hiding this comment.
and any other dbds loaded in here - i feel we should cut down if we're not using them as it means other facilities will need them too
| ## Start any sequence programs | ||
| #seq sncxxx,"user=faa59" |
| ## Analog data: up to 200 acquisition data channels | ||
| ## data channels are added in blocks of 20, so just do 20 channels for now (which is 40 16 bit words for 32bit float) | ||
| ## modbus function code 4 for read input register | ||
| drvModbusAsynConfigure("ACQ1", "$(DEVICE)", 0, 4, 8, 40, 0, 1000, "DAS240") |
There was a problem hiding this comment.
could we have the signature of this func in a comment above? i find it a bit annoying to have to go and search for this in the support module in eg. a support call otherwise, particularly for things with loads of args like this
| @@ -0,0 +1,40 @@ | |||
| # SPDX-FileCopyrightText: 2022 Argonne National Laboratory | |||
There was a problem hiding this comment.
can you actually have per-directory git ignores?
| @@ -0,0 +1 @@ | |||
| IOC for Sefram DAS240 No newline at end of file | |||
There was a problem hiding this comment.
local readme doesn't seem that needed here either
| SNCSEQ=$(SUPPORT)/seq/master | ||
| SQLITE=$(SUPPORT)/sqlite/master | ||
| SSCAN=$(SUPPORT)/sscan/master | ||
| STREAMDEVICE=$(SUPPORT)/StreamDevice/master |
There was a problem hiding this comment.
as per comment on dbds we're not using
2 participants
Description of work
Create IOC for Sefram DAS240
To test
See ISISComputingGroup/IBEX#8934
Acceptance criteria
List the acceptance criteria for the PR
galil-oldbranch based) and new (masterbranch based) drivers? If so have all appropriate PRs been created **Code Review
Functional Tests
..._0nwheren>1) run correctlymacLib: macroto find instances ofmacLib: macro [macro name] is undefined...Final steps