Ticket8688 add attributes to eurotherm#950
Conversation
LowriJenkins
left a comment
LowriJenkins
left a comment
There was a problem hiding this comment.
Small number of changes to some records that should be binary rather than analog.
Also, do we know the units we are working with for most of these values? if so should htey have an EGU field set on these records?
| field(PREC, "3") | ||
| } | ||
|
|
||
| record(ai, "$(P)SNBRKPST") { |
There was a problem hiding this comment.
This should probably be a bi as it appears to be a binary flag rather than an analog value
| field(CALC, "B < A") | ||
| } | ||
|
|
||
| record(ai, "$(P)AUTOMAN") { |
There was a problem hiding this comment.
This should probably be a bi as it appears to be an on/off value not an analog one
| field(PREC, "3") | ||
| } | ||
|
|
||
| record(ao, "$(P)AUTOMAN:SP") { |
There was a problem hiding this comment.
as above, but should be bo
| field(DTYP, "Soft Channel") | ||
| } | ||
|
|
||
| record(ai, "$(P)SIM:AUTOMAN") |
There was a problem hiding this comment.
as non simulation, this should be bi
| field(DTYP, "Soft Channel") | ||
| } | ||
|
|
||
| record(ai, "$(P)SIM:SNBRKPST") |
There was a problem hiding this comment.
as non simulation, this should be bi
|
Changes have been made as discussed previously. |
2 participants
Description of work
This is the IOC change for additional attributes for Eurotherm OPI required for better debugging.
To test
Fixes
Acceptance criteria
List the acceptance criteria for the PR
galil-oldbranch based) and new (masterbranch based) drivers? If so have all appropriate PRs been created **Code Review
Functional Tests
..._0nwheren>1) run correctlymacLib: macroto find instances ofmacLib: macro [macro name] is undefined...Final steps