[Refactor] Query Formatter Test Case Fixes#102
Merged
colinthebomb1 merged 1 commit intomainfrom Mar 31, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands QueryFormatter’s AST→mo_sql_parsing JSON conversion to cover additional SQL constructs so previously-disabled formatter test cases can be asserted again.
Changes:
- Re-enabled many
tests/test_query_formatter.pyassertions by comparing formatted SQL vs expected queries viamo_sql_parsing.parse(). - Enhanced
core/query_formatter.pyto supportSELECT DISTINCT,DISTINCT ON, subqueries inFROM/JOIN,NULL/IS NULL,CASE,INlists, arithmetic operators, andINTERVAL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/test_query_formatter.py | Uncomments/enables formatter assertions across many query fixtures. |
| core/query_formatter.py | Adds/adjusts formatting logic for DISTINCT, DISTINCT ON, subquery sources, more operators/expressions, and interval handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates the query formatter logic to support more complex test cases. All existing test cases now pass.
TODOs
Add UNION test cases and support them in formatter