Skip to content

Add Guestbook Response Sorting by fields - #12568

Open
stevenwinship wants to merge 8 commits into
developfrom
12524-sort-guestbook-responses
Open

Add Guestbook Response Sorting by fields#12568
stevenwinship wants to merge 8 commits into
developfrom
12524-sort-guestbook-responses

Conversation

@stevenwinship

Copy link
Copy Markdown
Contributor

What this PR does / why we need it: Modern UI needs to sort the output of the get guestbook response api

Which issue(s) this PR closes:#12524

Special notes for your reviewer:

Suggestions on how to test this: create multiple Datasets using a Guestbook and populate responses. Using the API retrieve the responses with various sort/order query parameters. Test with large numbers for performance hits due to the added db table joins.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

@stevenwinship stevenwinship self-assigned this Jul 29, 2026
@github-actions github-actions Bot added Feature: Guestbook GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA These changes are required for the Dataverse SPA Type: Feature a feature request labels Jul 29, 2026
@stevenwinship stevenwinship moved this to In Progress 💻 in IQSS Dataverse Project Jul 29, 2026
@stevenwinship stevenwinship added this to the 6.12 milestone Jul 29, 2026
@coveralls

coveralls commented Jul 29, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 24.996% (-0.006%) from 25.002% — 12524-sort-guestbook-responses into develop

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

Test Results

403 tests  ±0   388 ✅ +1   34m 6s ⏱️ - 4m 34s
 55 suites ±0    15 💤 ±0 
 55 files   ±0     0 ❌  - 1 

Results for commit 4d9267e. ± Comparison against base commit ad7ada1.

♻️ This comment has been updated with latest results.

@cmbz cmbz added FY27 Sprint 2 FY27 Sprint 2 (2026-07-15 - 2026-07-29) FY27 Sprint 3 FY27 Sprint 3 (2026-07-29 - 2026-08-12) labels Jul 29, 2026
@github-actions

This comment has been minimized.

@stevenwinship
stevenwinship force-pushed the 12524-sort-guestbook-responses branch from 6403b3f to ec51106 Compare July 31, 2026 21:13
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Comment thread src/main/java/edu/harvard/iq/dataverse/GuestbookResponseServiceBean.java Outdated
@github-actions

This comment has been minimized.

@stevenwinship
stevenwinship force-pushed the 12524-sort-guestbook-responses branch from a75946f to b82257e Compare August 5, 2026 17:50
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Aug 5, 2026
@stevenwinship stevenwinship removed their assignment Aug 5, 2026
@stevenwinship
stevenwinship force-pushed the 12524-sort-guestbook-responses branch from b82257e to dd1cb81 Compare August 5, 2026 21:10
@github-actions

This comment has been minimized.

@stevenwinship stevenwinship moved this from Ready for Review ⏩ to In Progress 💻 in IQSS Dataverse Project Aug 6, 2026
@stevenwinship stevenwinship self-assigned this Aug 6, 2026
@stevenwinship stevenwinship moved this from In Progress 💻 to Ready for Review ⏩ in IQSS Dataverse Project Aug 6, 2026
@stevenwinship stevenwinship removed their assignment Aug 6, 2026
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:12524-sort-guestbook-responses
ghcr.io/gdcc/configbaker:12524-sort-guestbook-responses

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature: Guestbook FY27 Sprint 2 FY27 Sprint 2 (2026-07-15 - 2026-07-29) FY27 Sprint 3 FY27 Sprint 3 (2026-07-29 - 2026-08-12) GREI Re-arch Issues related to the GREI Dataverse rearchitecture Size: 30 A percentage of a sprint. 21 hours. (formerly size:33) SPA These changes are required for the Dataverse SPA Type: Feature a feature request

Projects

Status: Ready for Review ⏩

Development

Successfully merging this pull request may close these issues.

Update guestbook responses to sort by guestbook response fields

4 participants