Locally FAIR Data#12319
Open
qqmyers wants to merge 48 commits intoIQSS:developfrom
Open
Conversation
used when dataverse.feature.add-publicobject-solr-field is not set
# Conflicts: # src/main/java/edu/harvard/iq/dataverse/search/SolrIndexServiceBean.java
# Conflicts: # src/main/java/edu/harvard/iq/dataverse/api/Access.java # src/main/java/edu/harvard/iq/dataverse/api/Datasets.java
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public Response getMakeDataCountMetricCurrentMonth(@Context ContainerRequestContext crc, @PathParam("id") String idSupplied, @PathParam("metric") String metricSupplied, @QueryParam("country") String country) { | ||
| String nullCurrentMonth = null; | ||
| return getMakeDataCountMetric(idSupplied, metricSupplied, nullCurrentMonth, country); | ||
| return getMakeDataCountMetric(crc, idSupplied, metricSupplied, nullCurrentMonth, country); |
Member
Author
There was a problem hiding this comment.
This alert isn't related to the changes in this PR. Could be handled as a new issue/PR.
# Conflicts: # src/main/java/edu/harvard/iq/dataverse/api/AbstractApiBean.java # src/main/java/edu/harvard/iq/dataverse/api/Dataverses.java
qqmyers
added
HDC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Implements the functionality described in "Locally FAIR" Data: Restricting Data Visibility in Dataverse Installations, allowing the visibility and accessibility of published collections and their published datasets/datafiles to be limited to specific groups.
Which issue(s) this PR closes:
Special notes for your reviewer: https://docs.google.com/document/d/1PPmPsAX8sbQYYdrU5s0Xc2d9YXw_5ROwkKaajT194P4/edit?usp=sharing and https://docs.google.com/document/d/1KBqRIkhRdJWCSs6wIRrnreJNLqWJoISIlqOZmDSTI9Q/edit?usp=sharing are additional resources.
Suggestions on how to test this: There are IT tests. For the UI, a superuser can add a user/group from the Collection/General Info pane and, once that's done, only the selected users should see new content in the collection. Reindexing would make existing published items disappear from search for unauthenticated users.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: inc.
Additional documentation: