Skip to content

Fix Preview URL: Suppress breadcrumbs#12111

Merged
landreev merged 4 commits intodevelopfrom
11085-fix-preview-breadcrumbs
Jan 29, 2026
Merged

Fix Preview URL: Suppress breadcrumbs#12111
landreev merged 4 commits intodevelopfrom
11085-fix-preview-breadcrumbs

Conversation

@sekmiller
Copy link
Copy Markdown
Contributor

@sekmiller sekmiller commented Jan 22, 2026

What this PR does / why we need it: Fixes an bug introduced after preview url update

Which issue(s) this PR closes:

Special notes for your reviewer:

Suggestions on how to test this: remember, that if you are logged in with privileges the breadcrumbs will show.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

@sekmiller sekmiller moved this to Ready for Review ⏩ in IQSS Dataverse Project Jan 22, 2026
@github-actions github-actions Bot added the Type: Feature a feature request label Jan 22, 2026
Copy link
Copy Markdown
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but I see that the header responds to this param and it was not set for the dataset page and was for the file page.
I'll approve - only question is whether it should have a one line release note.

@github-project-automation github-project-automation Bot moved this from Ready for Review ⏩ to Ready for QA ⏩ in IQSS Dataverse Project Jan 22, 2026
@sekmiller
Copy link
Copy Markdown
Contributor Author

@qqmyers I can add a release note, but I'm going to advocate for a patch since it's just one line in an xhtml file and a user noticed it.

@sekmiller sekmiller added the Type: Bug a defect label Jan 23, 2026
@landreev
Copy link
Copy Markdown
Contributor

@sekmiller

I can add a release note, but I'm going to advocate for a patch since it's just one line in an xhtml file and a user noticed it.

I'm happy to both test/merge, and to patch it in our own prod. But I agree with @qqmyers that it would be worth mentioning in a one-sentence release note as well, for everybody else. The bug seems important enough.

@landreev landreev self-assigned this Jan 27, 2026
@landreev landreev moved this from Ready for QA ⏩ to QA ✅ in IQSS Dataverse Project Jan 27, 2026
@landreev
Copy link
Copy Markdown
Contributor

@sekmiller
Great, thanks!
I've added the word "anonymized" there, merging now.
I will patch the xhtml page in prod. shortly. (it will take effect on each node next time payara is restarted there)

@landreev landreev merged commit c91f059 into develop Jan 29, 2026
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from QA ✅ to Merged 🚀 in IQSS Dataverse Project Jan 29, 2026
@landreev landreev removed their assignment Jan 29, 2026
@pdurbin pdurbin added this to the 6.10 milestone Jan 29, 2026
@cmbz cmbz added FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) FY26 Sprint 16 FY26 Sprint 16 (2026-01-28 - 2026-02-11) labels Jan 29, 2026
@scolapasta scolapasta moved this from Merged 🚀 to Done 🧹 in IQSS Dataverse Project Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FY26 Sprint 15 FY26 Sprint 15 (2026-01-14 - 2026-01-28) FY26 Sprint 16 FY26 Sprint 16 (2026-01-28 - 2026-02-11) Type: Bug a defect Type: Feature a feature request

Projects

Status: Done 🧹

Development

Successfully merging this pull request may close these issues.

Feature Request: Accessing a dataset via a private url should hide the hierarchy of Dataverses

6 participants