alternativeIdentifierType attribute in DataCite XML was always set to :unav for otherId fields from citation metadatablock#12034
Merged
scolapasta merged 3 commits intoIQSS:developfrom Feb 17, 2026
Conversation
stevenwinship
approved these changes
Jan 8, 2026
|
|
||
| for (DatasetFieldCompoundValue otherIdentifier : otherIdentifiers) { | ||
| String identifierType = null; | ||
| String identifierType = ":unav";; |
Contributor
There was a problem hiding this comment.
redundant semicolon. I'll approve it but feel free to remove it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Per discussion related to #11916 in https://docs.google.com/spreadsheets/d/1yvpIgD5tTst2Momu3RnzihmeEMvYH-TgfKjF7cdmJwg/edit?gid=0#gid=0, the processing of the Other Identifier fields to create the DataCite XML export/submission to DataCite has a bug that causes the identifier type to be set to :unav even when it is available (the otherIdAgency field has a value). This PR fixes that issue.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Add entries for the two Other Identifier fields (otherIdAgency, otherIdValue) and verify that the DataCite XML output includes a section like
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: fairly minor issue to include
Additional documentation: