Storage Quota/Upload Limit Integration

[ChengShi-1]

What this PR does / why we need it:

Show storage/file quotas on the Upload Files page

Which issue(s) this PR closes:

• Closes Feature Request: Show storage/file quotas on the Upload Files page; disable Files to Add button when limits reached #897

Special notes for your reviewer:

• I expect the upload limits will have more fields, but for now, it shows Storage Quota only

• When the file exceeds the storage quota, it would raise an error. It has been implemented before.

• The test coverage is not passing, but I solve it in other PR(Manage template)

Suggestions on how to test this:

• You may need to enable the setting and set upload limit through API first, to let the storage quotas set.
• Use the /settings API to enable or disable the enforcement of storage quotas that are defined across the instance via the following setting:
  curl -X PUT -d 'true' http://localhost:8080/api/admin/settings/:UseStorageQuotas
• To set or change the storage allocation quota for a collection:
  curl -X PUT -H "X-Dataverse-key:$API_TOKEN" -d $SIZE_IN_BYTES $SERVER_URL/api/dataverses/$ID/storage/quota
• Create a dataset, upload a file, then check the text above the upload box, "Select files or drag and drop into the upload widget. Maximum of 1,000 files per upload." should be shown and "Storage Quota: xx(the number you set minus the current file size) remaining" should also be shown if you set the number through PUT api above.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Yes, a screenshot above

Is there a release notes or changelog update needed for this change?:

Yes, changelog should be updated

Additional documentation:

[coveralls]

coverage: 97.77% (+0.4%) from 97.395%
when pulling 6381f92 on StorageQuota
into e0ddce8 on develop.

[ekraffmiller]

Looks good & works really nicely! just a couple of comments.

[ekraffmiller]

This should use the DatasetRepository, rather than directly calling the jsDataverse function

[ekraffmiller]

It would be good to have a FileUploadInput story that shows the file upload limit messages.

[ekraffmiller]

thanks for the updates, approved 👍

[jp-tosca]

@ChengShi-1 @ekraffmiller

I am looking into this. It seems that it is not very clear why this upload is failing:

Is there a way to put a warning or somehow emphasize the text "Storage quota: 128 B remaining" and also provide a more informative message on why this failed? The text "There was an error uploading this file." doesn't provide enough feedback to people to understand why it failed, and the user relies on having to read the text above.

Let me know what you think and if this would be an easy change.

[ChengShi-1]

@jp-tosca Thanks for the QA and your feedback. I agree your suggestion makes sense here.
However, the error message was implemented prior to this PR, so it isn’t covered in this change and I only addressed the text above. Also, since we may want to include this ASAP for the rollout. Can I just create a separate issue to handle this as a future optimization?

[ekraffmiller]

@jp-tosca I think it's a good idea to show the error message from the API, but it's not a simple one line fix, since it has to go through some layers in the UI, so I think given our time frame is best to do that as a separate follow up issue.

[jp-tosca]

The last item we discussed regarding to this PR and will be added as an improvement is the missing button "done".