Skip to content

Pr501 pcg #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaadelmann merged 7 commits into from
Jun 15, 2026
Merged

Pr501 pcg #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
60cf99e
Hoist PCG allocations out of solve loop
PaulFisch May 31, 2026
87a546e
this is the how to split
aaadelmann May 31, 2026
f1465da
Fix ALPINE particle view handle lifetimes
PaulFisch Jun 1, 2026
8b8d250
Merge remote-tracking branch 'origin/master' into pr501-pcg
aaadelmann Jun 10, 2026
4fd0688
address reviwers requests
aaadelmann Jun 15, 2026
fc0da17
delete file
aaadelmann Jun 15, 2026
f2c1938
Merge branch 'master' into pr501-pcg
aaadelmann Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions alpine/BumponTailInstabilityManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,10 @@ class BumponTailInstabilityManager : public AlpineManager<T, Dim> {

this->pcontainer_m->create(nlocal);

view_type* R = &(this->pcontainer_m->R.getView());
samplingR.generate(*R, rand_pool64);
view_type R = this->pcontainer_m->R.getView();
samplingR.generate(R, rand_pool64);

view_type* P = &(this->pcontainer_m->P.getView());
view_type P = this->pcontainer_m->P.getView();
Comment thread
aaadelmann marked this conversation as resolved.

double mu[Dim];
double sd[Dim];
Expand All @@ -288,12 +288,12 @@ class BumponTailInstabilityManager : public AlpineManager<T, Dim> {
// sample first nlocBulk with muBulk as mean velocity
mu[Dim - 1] = muBulk_m;
Kokkos::parallel_for(Kokkos::RangePolicy<int>(0, nlocBulk),
ippl::random::randn<double, Dim>(*P, rand_pool64, mu, sd));
ippl::random::randn<double, Dim>(P, rand_pool64, mu, sd));

// sample remaining with muBeam as mean velocity
mu[Dim - 1] = muBeam_m;
Kokkos::parallel_for(Kokkos::RangePolicy<int>(nlocBulk, nlocal),
ippl::random::randn<double, Dim>(*P, rand_pool64, mu, sd));
ippl::random::randn<double, Dim>(P, rand_pool64, mu, sd));

Kokkos::fence();
ippl::Comm->barrier();
Expand Down
8 changes: 4 additions & 4 deletions alpine/LandauDampingManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,18 +226,18 @@ class LandauDampingManager : public AlpineManager<T, Dim> {

this->pcontainer_m->create(nlocal);

view_type* R = &(this->pcontainer_m->R.getView());
samplingR.generate(*R, rand_pool64);
view_type R = this->pcontainer_m->R.getView();
samplingR.generate(R, rand_pool64);

view_type* P = &(this->pcontainer_m->P.getView());
view_type P = this->pcontainer_m->P.getView();

double mu[Dim];
double sd[Dim];
for (unsigned int i = 0; i < Dim; i++) {
mu[i] = 0.0;
sd[i] = 1.0;
}
Kokkos::parallel_for(nlocal, ippl::random::randn<double, Dim>(*P, rand_pool64, mu, sd));
Kokkos::parallel_for(nlocal, ippl::random::randn<double, Dim>(P, rand_pool64, mu, sd));
Kokkos::fence();
ippl::Comm->barrier();

Expand Down
8 changes: 4 additions & 4 deletions alpine/PenningTrapManager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,14 +202,14 @@ class PenningTrapManager : public AlpineManager<T, Dim> {

this->pcontainer_m->create(nlocal);

view_type* R = &(this->pcontainer_m->R.getView());
samplingR.generate(*R, rand_pool64);
view_type R = this->pcontainer_m->R.getView();
samplingR.generate(R, rand_pool64);

view_type* P = &(this->pcontainer_m->P.getView());
view_type P = this->pcontainer_m->P.getView();

double muP[Dim] = {0.0, 0.0, 0.0};
double sdP[Dim] = {1.0, 1.0, 1.0};
Kokkos::parallel_for(nlocal, ippl::random::randn<double, Dim>(*P, rand_pool64, muP, sdP));
Kokkos::parallel_for(nlocal, ippl::random::randn<double, Dim>(P, rand_pool64, muP, sdP));

Kokkos::fence();
ippl::Comm->barrier();
Expand Down
Loading
Loading