feat(files-sharing): show pending shares menu only if feature enabled#282
Open
printminion-co wants to merge 3 commits into
Open
feat(files-sharing): show pending shares menu only if feature enabled#282printminion-co wants to merge 3 commits into
printminion-co wants to merge 3 commits into
Conversation
printminion-co
marked this pull request as draft
July 17, 2026 14:08
printminion-co
marked this pull request as ready for review
July 17, 2026 15:22
printminion-co
force-pushed
the
feat/hide_pending_shares_menu_if_disabled
branch
4 times, most recently
from
July 24, 2026 09:22
7cbb3fa to
9cd18f3
Compare
Resolve the share manager through constructor injection instead of Server::get() so the listener follows the app's dependency-injection conventions. Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
# menu is removed on ./occ config:system:set --value true --type boolean -- sharing.enable_share_accept # menu is shown on ./occ config:system:set --value false --type boolean -- sharing.enable_share_accept Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
printminion-co
force-pushed
the
feat/hide_pending_shares_menu_if_disabled
branch
from
July 24, 2026 10:14
9cd18f3 to
a366b5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently the "pending shares" is always available if feature enabled or not
Documentation: https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/config_sample_php_parameters.html
Proposal
With this change the "pending shares" will be displayed only if feature is enabled.
"pending shares" menu item is shown on
./occ config:system:set --value true --type boolean -- sharing.enable_share_accept
"pending shares" menu item is removed on
./occ config:system:set --value false --type boolean -- sharing.enable_share_accept
run test via
Summary
TODO
Checklist