Added admin action 'view' on dms files#93
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughA new "view_element" action is being registered across the mail management system. The action is added to the Python action whitelist and then configured as an object button in three Dexterity content type profiles (dmsappendixfile, dmsmainfile, dmsommainfile), each opening the object's view in a new tab with "Manage portal" permission requirements. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
| <property name="description"></property> | ||
| <property name="url_expr">string:${object_url}/view</property> | ||
| <property name="icon_expr">string:${portal_url}/++resource++imio.annex/view_element.png</property> | ||
| <property name="available_expr">python:object.portal_type in ("dmsmainfile", "dmsommainfile", "dmsappendixfile")</property> |
There was a problem hiding this comment.
Ici, c'est un peu un hack pour ne pas dupliquer l'action "view" déjà présente sur les annexes, sur les annexes de dossiers par exemple. Par contre, l'action de imio.annex n'ouvre pas dans un nouvel onglet
sgeulette
left a comment
There was a problem hiding this comment.
J'adopterais exactement la même approche que pour le download.
Ajouter dans les types concernés dans basecontent et imio.dms.mail l'action view d'imio.annex
Summary by CodeRabbit
Release Notes