Skip to content

Fixed duplicated download action#92

Merged
sgeulette merged 3 commits intomasterfrom
PARAF-307/download_action
Feb 25, 2026
Merged

Fixed duplicated download action#92
sgeulette merged 3 commits intomasterfrom
PARAF-307/download_action

Conversation

@chris-adam
Copy link
Copy Markdown
Contributor

@chris-adam chris-adam commented Feb 20, 2026

Est-ce nécessaire de faire une migration pour ce changement ?

Summary by CodeRabbit

Release Notes

  • New Features
    • Introduced a Download action for main file objects, providing users with direct download functionality. A Download button is now available in the object toolbar, appearing when applicable, and opens content in a new tab.

@chris-adam chris-adam changed the title Paraf 307/download action Fixed duplicated download action Feb 20, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 20, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

A new Download action is added to the dmsommainfile content type definition, enabling users to download files when a condition is met. Additionally, test fixture data is updated to reflect revised PDF file sizes in the mail session annotations.

Changes

Cohort / File(s) Summary
Type Configuration
imio/dms/mail/profiles/default/types/dmsommainfile.xml
Added Download action with category object_buttons, conditional display via python:object.show_download(), View permission, and URL target ${object/absolute_url}/@@download opening in new tab.
Test Fixtures
imio/dms/mail/tests/test_adapters.py
Updated PDF file size metadata in mail session annotation fixtures from 23291 to 27330 bytes in two test cases.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A download button hops into view,
When show_download() says it's true—
Files dance through portals, swift and bright,
In a brand new tab, oh what a sight!
download_icon.png leads the way,
Where PDF files frolic and play! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fixed duplicated download action' accurately describes the main change—adding a Download action to the dmsommainfile type configuration.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch PARAF-307/download_action

Comment @coderabbitai help to get the list of available commands and usage tips.

@chris-adam chris-adam requested a review from sgeulette February 20, 2026 12:15
@sgeulette sgeulette merged commit e6d099b into master Feb 25, 2026
1 check passed
@sgeulette sgeulette deleted the PARAF-307/download_action branch February 25, 2026 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants