[FIX] #47986 UI: update Text and Textarea default value#11714
Open
thibsy wants to merge 1 commit into
Open
Conversation
thibsy
added
bugfix
kitchen sink
php
These `UI\Component\Input\Field` components cannot handle `null` as default value. Their constraint for requirement and default operations rely on working with a string. Hence the default value is changed to an empty string (`""`). * Fix https://mantis.ilias.de/view.php?id=47986
thibsy
force-pushed
the
fix/11/ui-text-inputs-with-null
branch
from
cc90f6e to
bf3a1cc
Compare
Contributor
Author
|
It would be nice if someone were to shepherd this (review only, I will integrate myself) and verify this change on some of ILIAS' complex forms that are implemented with the UI framework. |
Contributor
|
I did not find any errors on forms with this fix. But there is a behavioral change. First i feared the handling of value=null changed, which could lead to forms expecting null but getting an empty string now. But after digging deeper I discovered that using null as value was not allowed prior to commit f42c5fe, which broke the forms presumably. So I don't think this new behavior converting null to an empty string breaks anything. I would approve this PR. |
fwolf-ilias
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
These
UI\Component\Input\Fieldcomponents cannot handlenullas default value. Their constraint for requirement and default operations rely on working with a string. Hence the default value is changed to an empty string ("").This fixes https://mantis.ilias.de/view.php?id=47986.
Kind regards,
@thibsy