Skip to content

[FIX] Auth: Skip login-attempt counting for accounts without local auth #11712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjansenDatabay merged 1 commit into from
Jul 1, 2026
Merged

[FIX] Auth: Skip login-attempt counting for accounts without local auth #11712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion components/ILIAS/Authentication/classes/Frontend/class.ilAuthFrontend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,19 @@ protected function handleLoginAttempts(): void
$usr_id_candidates = [];
foreach (array_filter($auth_modes) as $auth_mode) {
if ((int) $auth_mode === ilAuthUtils::AUTH_LOCAL) {
$usr_id_candidates[] = ilObjUser::_lookupId($this->getCredentials()->getUsername());
$local_usr_id = ilObjUser::_lookupId($this->getCredentials()->getUsername());
// Mantis #47987: A failed local login must only count against an
// account that can actually be authenticated locally. Without this
// check, external accounts (e.g., Shibboleth/SAML) whose login name
// is entered in the local login form get their login attempts
// incremented and are eventually deactivated - even though a local
// login is impossible for them because "Allow Local Authentication"
// is disabled. This mirrors the gate in ilAuthProviderDatabase.
if (is_int($local_usr_id) && $local_usr_id > 0 && ilAuthUtils::isLocalPasswordEnabledForAuthMode(
(int) ilAuthUtils::_getAuthMode(ilObjUser::_lookupAuthMode($local_usr_id))
Comment thread
thojou marked this conversation as resolved.
)) {
$usr_id_candidates[] = $local_usr_id;
}
continue;
}

Expand Down
Loading