Skip to content

fix color for glyphs on button:hover#11711

Open
rotegras wants to merge 1 commit into
ILIAS-eLearning:release_10from
rotegras:fix-47806-ui-button-glyph-hover
Open

fix color for glyphs on button:hover#11711
rotegras wants to merge 1 commit into
ILIAS-eLearning:release_10from
rotegras:fix-47806-ui-button-glyph-hover

Conversation

@rotegras

Copy link
Copy Markdown
Contributor

Fix hover color for glyphs in buttons on hover and focus

@rotegras rotegras requested a review from thibsy June 26, 2026 14:31
@rotegras

Copy link
Copy Markdown
Contributor Author

Hi @thibsy I've been working on some other Mantis Bugs.

Mantis Bug: 47806

Solves Problem in ILIAS 10 (Cherry Pick probably necessary for 11 and Trunk)

@thibsy

thibsy commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Hi @rotegras,

for this directory you do not need my approval. #11709 touched UI framework template files, that is why I intervened there. Sometimes there are some caveats. But thx for being cautious =).

This directory is @BettyFromHH and your turf. Feel free to proceed how you see fit. Nonetheless a piece of advice: it will be a lot easier to cherry-pick these changes if you create one commit for the actual SCSS change and another for the compilation of the entire CSS stylesheet. This way you can only pick the SCSS changes (mostly without conflict) and simply create a new commit on another release branch that builds the stylesheet. You can also read about these practises in #10956 (should be integrated sometime soon).

Kind regards,
@thibsy

@oliversamoila

Copy link
Copy Markdown
Contributor

Hi @rotegras.
I’d like to ask a question that might sound a bit innocent: Why are all the colour parameters being changed from, for example, background-color: #e2e8ef; to rgb(226.2857142857, 231.6428571429, 238.7142857143);?
I’ve noticed this in several open PRs now, and it’s confusing me.

A quick explanation would be much appreciated.

Kind regards,
Oliver

@mjansenDatabay mjansenDatabay added the css/html Pull requests that propose changes to CSS/SCSS or HTML files. label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css/html Pull requests that propose changes to CSS/SCSS or HTML files. kitchen sink

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants