Detach unmapped OIDC roles during user sync#11702
Open
tiran133 wants to merge 1 commit into
Open
Conversation
Update OIDC role synchronisation, so existing users lose mapped global roles when their provider claims no longer match the configured role mapping. Keep role matching behaviour for new users unchanged, while writing a Role detach action for existing users when a mapped claim is missing or does not contain the configured value.
Contributor
|
Hi @tiran133 , thanks for the PR. I will label this PR with "jour fixe" since this is a behavioural change. If no one objects to apply this change for the stable releases, I will merge it. Best regards, |
Author
|
Hey, thank you! One question I have. We currently use Ilias 10. That's why I added this to ILIAS-eLearning:release_10 Once this is merged will it be included in to Ilias 11 automatically? Or do I need to create another PR. Not so familiar with the process here. This is my first contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update OIDC role synchronisation, so existing users lose mapped global
roles when their provider claims no longer match the configured role
mapping.
Keep role matching behaviour for new users unchanged, while writing a
Role detach action for existing users when a mapped claim is missing or
does not contain the configured value.
Fixes
https://mantis.ilias.de/view.php?id=30142
It would be a change of behaviour, it might need to be gated behind a UI setting?