Enable LOM metadata support for Learning Sequences#11675
Open
kevenClausenKPG wants to merge 4 commits into
Open
Enable LOM metadata support for Learning Sequences#11675kevenClausenKPG wants to merge 4 commits into
kevenClausenKPG wants to merge 4 commits into
Conversation
Contributor
Author
|
Hey @schmitz-ilias , could you please take a look at my metadata implementation for the LSO and give me some feedback? |
schmitz-ilias
left a comment
Contributor
There was a problem hiding this comment.
Hi @kevenClausenKPG,
everything related to Metadata looks good all in all, just a few points:
- The new
InitLOMForLearningSequenceMigrationneeds to be added toilLearningSequenceSetupAgent::getMigrations, otherwise it will not be shown. - It's a bit strange that there is no
LuceneObjectDefinition.xmlfor Learning Sequences at all, I guess Lucene support for the object was just never implemented. Maybe a small project for another day ^^ - AdvancedMetaData also needs to be added as a tail dependency in
ilLearningSequenceExporter(similar to LOM), see for an exampleilGroupExporter. - Unrelated to Metadata: I haven't looked at this too deeply, but the changes in ilObjLearningSequenceSettingsGUI::update look fishy to me. It seems like the form input related to title, description, and online-status will not be processed anymore?
Note that Taxonomies are currently mostly independent of MetaData, so I can't review that part of the implementation. Let me know if anything is unclear!
Cheers, Tim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes Learning Object Metadata (LOM) support for the Learning Sequence following
components/ILIAS/MetaData/docs/enabling_lom.md.It includes:
createMetaData(),updateMetaData(), anddeleteMetaData()in the LSO object lifecycleMeta Datatab viailObjectMetaDataGUI::getTab()(noCUSTOM_METADATAgating) and show LOM sections on the info screen viaaddMetaDataSections(..., 0, 'lso')components/ILIAS/MetaData(md) so LOM sets are correctly remapped on importhttps://docu.ilias.de/go/wiki/wpage_7807_1357