Skip to content

[FIX] #44421 Form: announce legacy radio group labels to screenreaders #11310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marvimarv wants to merge 1 commit into
base: release_10
Choose a base branch
from
+7 −2
Open

[FIX] #44421 Form: announce legacy radio group labels to screenreaders #11310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/ILIAS/Form/classes/class.ilRadioGroupInputGUI.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ public function insert(ilTemplate $a_tpl): void
public function render(): string
{
$tpl = new ilTemplate("tpl.prop_radio.html", true, true, "components/ILIAS/Form");
$group_label = $this->getHiddenTitle() !== ""
? $this->getHiddenTitle()
: $this->getTitle();
$tpl->setVariable("GROUP_LABEL", $group_label);

foreach ($this->getOptions() as $option) {
// information text for option
Expand Down
5 changes: 3 additions & 2 deletions components/ILIAS/Form/templates/default/tpl.prop_radio.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<div id="{ID}">
<fieldset id="{ID}" style="border:0;margin:0;padding:0;min-width:0;">
<legend class="ilAccHeadingHidden">{GROUP_LABEL}</legend>
<!-- BEGIN prop_radio_option -->
<div class="radio">
<label class="radio-inline"><input <!-- BEGIN described_by -->aria-describedby="desc_{DESCRIBED_BY_FIELD_ID}" <!-- END described_by -->type="radio" onclick="il.Form.showSubForm('subform_{OP_ID}', '{FID}', null);" name="{POST_VAR}" id="{OP_ID}" value="{VAL_RADIO_OPTION}" {CHK_RADIO_OPTION} {DISABLED}/>
Expand All @@ -12,4 +13,4 @@
<!-- END radio_option_subform -->
<!-- END prop_radio_option -->
{HIDDEN_INPUT}
</div>
</fieldset>
Loading