Fixed autosaving of playlist not working on linux#357
Open
Conversation
Member
|
Nice thank you for catching this. I will:
|
Member
|
Aah I think now I understand the issue. I also debugged the code a bit on Windows and the QUrl code you added does not work on windows. |
Member
|
@nolyn I removed all the QUrl stuff and am just using the QDir::absolut and relative path functions. Can you double check if this works for the bug that you discovered? For me YUView is now able to get the aboslute file path for all files on windows and mac. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I actually never used the autosave feature so far. but now that i'm looking into #353 I realized it doesn't work for me at all in the current version. The reason is that on Linux absolute paths are saved as "file:///xxx" for path "/xxx". QUrl does this. When reading QString was used and no conversion to the latter (required) representation occurred. Fixed by letting QUrl do the conversion. Strangely it only affects the autosave feature. Playlists stored to files worked before. It was still able to find the files using the relative paths.
Why do we actually need QUrl for storing paths in the first place? I guess YUView can also load web links?
The change needs to be tested again on Windows and Mac, which I can't do. I suspect the bug was also present on Mac before.