fix(deps): bump moby/go-archive to v0.3.3 for the tar path-traversal fix - #214
Merged
Conversation
Dependabot alert #16 (high): a crafted tar archive can write outside the extraction directory in moby/go-archive < 0.3.0. The dependency is indirect and test-only — it reaches us through testcontainers-go, which the integration suite uses via test/awslocal. testcontainers-go is already at its latest (v0.44.0) and still requires v0.2.0, so upstream has not carried the fix yet; bump it directly instead. v0.3.3 is the current patch on the fixed line. moby/sys/user rides along as a transitive requirement of the bump. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015aZ5qHYBsde5ysgUrRmbwD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the one open Dependabot alert on
main— #16, high severity:a crafted tar archive can write outside the extraction directory in
moby/go-archivebefore v0.3.0.Why a direct bump of an indirect dependency
go mod whyputs it behind testcontainers:So the reachable exposure is test-only — the integration suite extracting
image layers, not the service handling feed data. It is still worth fixing
rather than dismissing: it is the only thing standing between this repo and a
clean security tab, and
mainis about to be a public branch.testcontainers-go is already at its latest release (v0.44.0) and still requires
go-archivev0.2.0, so there is no upstream version to move to — hence thedirect requirement. v0.3.3 is the current patch on the fixed line.
moby/sys/userv0.4.0 → v0.4.1 rides along as a transitive requirement.Verification
Because the consumer is behind the
integrationbuild tag, an untagged buildproves nothing on its own — so this was checked both ways:
go build ./...clean;go vet -tags=integration ./...clean, whichtypechecks the testcontainers call sites against the new version.
go test -race ./...— 48/48 packages ok.golangci-lint run ./...— 0 issues../internal/coord/redisand./internal/sink/natspass, and./internal/coord/dynamodbpasses — that last one is the LocalStack paththrough
test/awslocal, i.e. the exact consumer named above.