Honor EdgeZero app config store default#879
Open
ChristianPavilonis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[stores.config].defaultinedgezero.tomlat build time.trusted_server_configas the current default while retaining EdgeZero store name/key environment overrides.Changes
crates/trusted-server-core/build.rsedgezero.tomland expose its default config-store ID as a compile-time value.crates/trusted-server-core/src/config_payload.rs,settings_data.rscrates/trusted-server-adapter-fastly/src/main.rscrates/trusted-server-adapter-cloudflare/app_configkey.docs/guide/configuration.mdCloses
Closes #866
Test plan
cargo test-fastly && cargo test-axumcargo clippy-fastly && cargo clippy-axumcargo fmt --all -- --checkcd crates/trusted-server-js/lib && npx vitest runcd crates/trusted-server-js/lib && npm run formatcd docs && npm run formatcargo build --package trusted-server-adapter-fastly --release --target wasm32-wasip1fastly compute servecargo test-cloudflare;cargo clippy-cloudflare && cargo clippy-cloudflare-wasm; integration config generator and non-ignored integration tests; Spin, CLI, and parity testsChecklist
unwrap()in production code — useexpect("should ...")tracingmacros (notprintln!) — no runtime logging added; build-scriptprintln!calls emit required Cargo directives