Secure cookies on production, check next redirect, permission checks for partials#4843
Open
frjo wants to merge 4 commits into
Open
Secure cookies on production, check next redirect, permission checks for partials#4843frjo wants to merge 4 commits into
frjo wants to merge 4 commits into
Conversation
Contributor
|
@frjo was there a reason secure cookies weren't the default before? I never noticed that |
Member
Author
|
@wes-otf We did not want it for local or test but the solution is not optimal since you need to set a setting to get secure cookies, it should be the default for production. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.