Fix CI/CD workflow false negatives for LICENSE detection and Poetry builds

[Copilot]

The CI/CD review workflow incorrectly reported missing documentation files and build failures due to hardcoded assumptions about file naming and Python build tooling.

Changes

• LICENSE detection: Check for both LICENSE and LICENSE.md, preferring whichever exists

  if [ -f "LICENSE.md" ] || [ -f "LICENSE" ]; then
    license_file=$([ -f "LICENSE.md" ] && echo "LICENSE.md" || echo "LICENSE")

• Poetry build support: Detect pyproject.toml with Poetry config and install dependencies accordingly

  if [ -f "pyproject.toml" ] && grep -q 'tool.poetry' pyproject.toml; then
    if pip install poetry; then
      poetry install && echo "BUILD_SUCCESS=true" >> $GITHUB_OUTPUT

• Python build precedence: Poetry → requirements.txt → setup.py with proper error handling

This eliminates false negatives for repositories using standard LICENSE naming (no extension) and modern Python packaging (Poetry).

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Complete CI/CD Review - 2025-12-08</issue_title>
<issue_description># Complete CI/CD Agent Review Report

Review Date: $(date -u +"%Y-%m-%d %H:%M:%S UTC")
Repository: HyperionGray/python-chrome-devtools-protocol
Branch: master
Trigger: push

Executive Summary

This comprehensive review covers:

• ✅ Code cleanliness and file size analysis
• ✅ Test coverage and Playwright integration
• ✅ Documentation completeness and quality
• ✅ Build functionality verification

Detailed Findings

Build Status

Build result: false

Code Cleanliness Analysis

Large Files (>500 lines):

4634 lines: ./cdp/network.py
4004 lines: ./cdp/page.py
2673 lines: ./cdp/css.py
2438 lines: ./cdp/storage.py
2189 lines: ./cdp/dom.py
1838 lines: ./cdp/audits.py
1663 lines: ./cdp/emulation.py
1589 lines: ./cdp/runtime.py
1405 lines: ./cdp/debugger.py
1397 lines: ./cdp/overlay.py
1063 lines: ./generator/generate.py
979 lines: ./generator/test_generate.py
876 lines: ./cdp/dom_snapshot.py
819 lines: ./cdp/browser.py
790 lines: ./cdp/target.py
701 lines: ./cdp/input_.py
668 lines: ./cdp/accessibility.py
626 lines: ./cdp/bluetooth_emulation.py
606 lines: ./cdp/web_audio.py
581 lines: ./cdp/web_authn.py
569 lines: ./cdp/preload.py
528 lines: ./cdp/indexed_db.py
518 lines: ./cdp/security.py
507 lines: ./cdp/fetch.py

Documentation Analysis

Essential Documentation Files:

✅ README.md (424 words)
❌ CONTRIBUTING.md (missing)
❌ LICENSE.md (missing)
❌ CHANGELOG.md (missing)
❌ CODE_OF_CONDUCT.md (missing)
❌ SECURITY.md (missing)

README.md Content Check:

✅ Contains 'Installation' section
✅ Contains 'Usage' section
✅ Contains 'Features' section
⚠️ Missing 'Contributing' section
✅ Contains 'License' section
✅ Contains 'Documentation' section
✅ Contains 'Examples' section
⚠️ Missing 'API' section

Next Steps - Amazon Q Review

After reviewing these GitHub Copilot agent findings, Amazon Q will provide additional insights:

• Security analysis
• Performance optimization opportunities
• AWS best practices
• Enterprise architecture patterns

Action Items Summary

• Review and address code cleanliness issues
• Fix or improve test coverage
• Update documentation as needed
• Resolve build issues
• Wait for Amazon Q review for additional insights

---

This issue was automatically generated by the Complete CI/CD Review workflow.
Amazon Q review will follow automatically.
</issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes Complete CI/CD Review - 2025-12-08 #48

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

---

Note

Improves the CI review workflow to avoid false negatives in docs and Python builds.

• Documentation check: Special-cases LICENSE.md to accept either LICENSE or LICENSE.md, reporting as LICENSE with word count
• Python build: Detects pyproject.toml with tool.poetry, installs Poetry, runs poetry install; falls back to requirements.txt, then setup.py (pip install -e .)

^{Written by Cursor Bugbot for commit 2d6a23e. Configure here.}

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d6a23e07e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[chatgpt-codex-connector]

Fall back when Poetry install fails

In the build step, once pyproject.toml contains tool.poetry, this branch always executes; if pip install poetry fails (e.g., transient PyPI/network issues or a constrained runner), the script only logs a warning and never reaches the requirements.txt or setup.py branches because the outer if already matched. Repos that ship both Poetry metadata and a requirements.txt fallback will now be reported as BUILD_SUCCESS=false even though the requirements-based build could still succeed, which is a regression compared to the prior behavior.

Useful? React with 👍 / 👎.

[cursor]

Poetry failure prevents fallback to alternative build methods

Low Severity

When pyproject.toml with tool.poetry is detected but Poetry installation fails (line 505), the code prints a warning and exits the block, but the elif structure means requirements.txt and setup.py fallbacks are never attempted. For repositories that have both Poetry configuration and requirements.txt as backup, if pip install poetry fails due to environment constraints, BUILD_SUCCESS remains false even though the fallback could have worked. This could cause the same type of false negatives the PR aims to fix.

Additional Locations (1)

• .github/workflows/auto-complete-cicd-review.yml#L516-L525