feat(evlog): allow to configure request credentials in client logs & browser drain#232
Merged
HugoRCD merged 4 commits intoHugoRCD:mainfrom Mar 24, 2026
Merged
Conversation
|
@MrLightful is attempting to deploy a commit to the HRCD Projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thank you for following the naming conventions! 🙏 |
commit: |
1ab8d1a to
72a6027
Compare
72a6027 to
84926ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Description
Summary
Motivation
The browser drain & client log transport hardcode credentials: 'same-origin' in its fetch call. This works when the app and ingest endpoint share the same origin, but fails to send cookies/auth for cross-origin requests — a common scenario in local development (e.g., app on localhost:5173, API on localhost:3000) and production setups where the ingest endpoint lives on a separate domain or subdomain (e.g., app on app.company.com, API on api.company.com). Making this configurable unblocks these use cases without changing default behavior.
Usage
📝 Checklist