Skip to content

fix(nitro): make evlogErrorHandler compatible with TanStack Start middleware API#220

Merged
HugoRCD merged 1 commit intomainfrom
fix/evlog-error-handler-tanstack-compat
Mar 21, 2026
Merged

fix(nitro): make evlogErrorHandler compatible with TanStack Start middleware API#220
HugoRCD merged 1 commit intomainfrom
fix/evlog-error-handler-tanstack-compat

Conversation

@HugoRCD
Copy link
Owner

@HugoRCD HugoRCD commented Mar 21, 2026

Summary

  • evlogErrorHandler now accepts both (next) and ({ next }) signatures
  • TanStack Start's createMiddleware().server() passes { next } (an object), but evlogErrorHandler previously expected next directly as a function argument
  • This caused a runtime error in newer TanStack Start versions (>= 1.166.x), requiring users to wrap the handler manually

Before (workaround needed):

createMiddleware().server(({ next }) =>
  evlogErrorHandler(async () => await next())
)

After (works directly):

createMiddleware().server(evlogErrorHandler)

Fixes #137

@vercel
Copy link

vercel bot commented Mar 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
evlog-docs Ready Ready Preview, Comment, Open in v0 Mar 21, 2026 2:32pm

@github-actions github-actions bot added the bug Something isn't working label Mar 21, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2026

Thank you for following the naming conventions! 🙏

@github-actions
Copy link
Contributor

Benchmark report

Bundle size

Threshold: 5% · 🔴 larger · 🟡 warning · 🟢 smaller · ⚪ unchanged · 🆕 new

Status Entry Base (gzip) Current (gzip) Change Raw delta
framework/nitro 6.87 kB 6.91 kB +0.5% +97 B
logger 3.78 kB 3.78 kB 0.0% 0 B
framework/next 3.02 kB 3.02 kB 0.0% 0 B
framework/vite 2.37 kB 2.37 kB 0.0% 0 B
adapter/sentry 2.34 kB 2.34 kB 0.0% 0 B
adapter/otlp 2.10 kB 2.10 kB 0.0% 0 B
framework/ai 1.98 kB 1.98 kB 0.0% 0 B
enrichers 1.92 kB 1.92 kB 0.0% 0 B
framework/sveltekit 1.54 kB 1.54 kB 0.0% 0 B
adapter/posthog 1.50 kB 1.50 kB 0.0% 0 B
adapter/fs 1.41 kB 1.41 kB 0.0% 0 B
utils 1.41 kB 1.41 kB 0.0% 0 B
pipeline 1.35 kB 1.35 kB 0.0% 0 B
adapter/axiom 1.32 kB 1.32 kB 0.0% 0 B
browser 1.21 kB 1.21 kB 0.0% 0 B
error 1.21 kB 1.21 kB 0.0% 0 B
framework/nestjs 1.21 kB 1.21 kB 0.0% 0 B
adapter/better-stack 1.09 kB 1.09 kB 0.0% 0 B
framework/elysia 1.05 kB 1.05 kB 0.0% 0 B
framework/fastify 1010 B 1010 B 0.0% 0 B
workers 960 B 960 B 0.0% 0 B
framework/express 702 B 702 B 0.0% 0 B
framework/hono 595 B 595 B 0.0% 0 B
toolkit 241 B 241 B 0.0% 0 B
core (index) 205 B 205 B 0.0% 0 B
client 118 B 118 B 0.0% 0 B
types 31 B 31 B 0.0% 0 B
Total 42.46 kB 42.49 kB +0.1% +97 B

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 21, 2026

npm i https://pkg.pr.new/evlog@220
npm i https://pkg.pr.new/@evlog/nuxthub@220

commit: 550ad08

@HugoRCD HugoRCD merged commit b0c26d5 into main Mar 21, 2026
16 of 17 checks passed
@HugoRCD HugoRCD deleted the fix/evlog-error-handler-tanstack-compat branch March 21, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Tanstack Support

1 participant