Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions src/main/java/com/hubspot/jinjava/lib/tag/CallTag.java
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,40 @@ public String getName() {

@Override
public String interpret(TagNode tagNode, JinjavaInterpreter interpreter) {
String macroExpr = "{{" + tagNode.getHelpers().trim() + "}}";
String macroCallExpr = tagNode.getHelpers().trim();

LinkedHashMap<String, Object> argNamesWithDefaults = new LinkedHashMap<>();

if (macroCallExpr.startsWith("(")) {
int closeIdx = macroCallExpr.indexOf(')');
if (closeIdx != -1) {
String params = macroCallExpr.substring(1, closeIdx).trim();
if (!params.isEmpty()) {
MacroTag.populateArgNames(
tagNode.getLineNumber(),
interpreter,
params,
argNamesWithDefaults
);
}
macroCallExpr = macroCallExpr.substring(closeIdx + 1).trim();
}
}

String macroExpr = "{{" + macroCallExpr + "}}";

try (InterpreterScopeClosable c = interpreter.enterNonStackingScope()) {
LinkedHashMap<String, Object> args = new LinkedHashMap<>();
MacroFunction caller = new MacroFunction(
tagNode.getChildren(),
"caller",
args,
argNamesWithDefaults,
true,
interpreter.getContext(),
interpreter.getLineNumber(),
interpreter.getPosition()
);
interpreter.getContext().addGlobalMacro(caller);
interpreter.getContext().put(caller.getName(), caller);

return interpreter.render(macroExpr);
}
Expand Down
7 changes: 7 additions & 0 deletions src/test/java/com/hubspot/jinjava/lib/tag/CallTagTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,13 @@ public void itDoesNotDoubleCountCallTagTowardsDepth() throws IOException {
}
}

@Test
public void testCallerArgsFn() {
String result = interpreter.render(fixture("caller_args"));
System.out.println(result);
assertThat(result).isEqualTo(fixture("caller_args.expected"));
}

private String fixture(String name) {
try {
return Resources.toString(
Expand Down
9 changes: 9 additions & 0 deletions src/test/resources/tags/calltag/caller_args.expected.jinja
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
start
before
#a b c#
after

before
caller is undefined => #a b#
after
stop
17 changes: 17 additions & 0 deletions src/test/resources/tags/calltag/caller_args.jinja
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
start
{% macro test(arg1, arg2) -%}
before
{%- if caller is undefined %}
caller is undefined => #{{ arg1 }} {{ arg2 }}#
{%- else %}
{{ caller(arg1, arg2) }}
{%- endif %}
after
{%- endmacro -%}

{% call(arg1, arg2, arg3 = "c") test({"a_key": "a"}, "b") -%}
#{{ arg1.a_key }} {{ arg2 }} {{ arg3 }}#
{%- endcall %}

{{ test("a", "b") }}
stop