Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"eslint-plugin-prettier": "^4.0.0",
"eslint-plugin-react": "^7.27.1",
"formdata-polyfill": "^4.0.10",
"gh-pages": "^3.2.3",
"gh-pages": "^5.0.0",
"har-validator": "^5.1.3",
"husky": "^7.0.4",
"jest": "^27.3.1",
Expand All @@ -85,7 +85,7 @@
"npm-run-all": "^4.1.5",
"prettier": "^2.5.0",
"rimraf": "^3.0.2",
"rollup": "^1.14.6",
"rollup": "^2.80.0",
"rollup-plugin-alias": "^1.5.2",
"rollup-plugin-babel": "^4.4.0",
"rollup-plugin-commonjs": "^10.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/@pollyjs/adapter-fetch/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@
"@pollyjs/core": "^6.0.5",
"@pollyjs/persister-local-storage": "^6.0.5",
"@pollyjs/persister-rest": "^6.0.5",
"rollup": "^1.14.6"
"rollup": "^2.80.0"
}
}
4 changes: 2 additions & 2 deletions packages/@pollyjs/adapter-node-http/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"@pollyjs/persister-fs": "^6.0.5",
"form-data": "^4.0.0",
"get-stream": "^6.0.1",
"node-fetch": "^2.6.6",
"rollup": "^1.14.6"
"node-fetch": "^3.3.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-fetch bumped to v3 ESM-only breaking change

High Severity

The PR description states node-fetch goes from 2.6.6 to 2.6.7, but these packages actually bump to ^3.3.2. node-fetch v3 is ESM-only, which is incompatible with the CommonJS build pipeline used here (via rollup-plugin-commonjs). Code importing { Response } from node-fetch in test helpers and native-request.js will break because v3 has a different module format and API surface.

Additional Locations (1)

Fix in Cursor Fix in Web

"rollup": "^4.59.0"
}
}
4 changes: 2 additions & 2 deletions packages/@pollyjs/adapter-puppeteer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@
"devDependencies": {
"@pollyjs/core": "^6.0.5",
"@pollyjs/persister-fs": "^6.0.5",
"node-fetch": "^2.6.6",
"node-fetch": "^3.3.2",
"puppeteer": "1.10.0",
"rollup": "^1.14.6"
"rollup": "^4.59.0"
}
}
2 changes: 1 addition & 1 deletion packages/@pollyjs/adapter-xhr/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@
"devDependencies": {
"@pollyjs/core": "^6.0.5",
"@pollyjs/persister-rest": "^6.0.5",
"rollup": "^1.14.6"
"rollup": "^4.59.0"
}
}
2 changes: 1 addition & 1 deletion packages/@pollyjs/adapter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,6 @@
"@pollyjs/utils": "^6.0.1"
},
"devDependencies": {
"rollup": "^1.14.6"
"rollup": "^4.59.0"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rollup v4 incompatible with existing v1-era plugins

High Severity

The PR description says rollup bumps from 1.14.6 to 2.80.0, but many packages are actually bumped to ^4.59.0. The build configs in scripts/rollup/ use legacy plugins (rollup-plugin-babel, rollup-plugin-commonjs, rollup-plugin-node-resolve, etc.) that are only compatible with rollup v1/v2. Rollup v4 requires the @rollup/plugin-* namespace replacements, so builds for these packages will fail.

Additional Locations (2)

Fix in Cursor Fix in Web

}
}
2 changes: 1 addition & 1 deletion packages/@pollyjs/cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"devDependencies": {
"npm-run-all": "^4.1.5",
"rimraf": "^3.0.2",
"rollup": "^1.14.6"
"rollup": "^4.59.0"
},
"bin": {
"polly": "./bin/cli.js"
Expand Down
2 changes: 1 addition & 1 deletion packages/@pollyjs/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,6 @@
"devDependencies": {
"@pollyjs/adapter": "^6.0.4",
"@pollyjs/persister": "^6.0.5",
"rollup": "^1.14.6"
"rollup": "^4.59.0"
}
}
6 changes: 3 additions & 3 deletions packages/@pollyjs/node-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,15 +40,15 @@
},
"dependencies": {
"@pollyjs/utils": "^6.0.1",
"body-parser": "^1.19.0",
"body-parser": "^2.2.2",
"cors": "^2.8.5",
"express": "^4.17.1",
"express": "^5.2.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

express and body-parser bumped to incompatible major versions

High Severity

The PR description says body-parser goes to 1.20.3 and express to 4.22.0, but this package actually bumps to body-parser@^2.2.2 and express@^5.2.1. Express 5 and body-parser v2 are major versions with breaking API changes. The existing code uses import bodyParser from 'body-parser' (default export) and Express 4 patterns like express.Router() — these may behave differently or fail under the new major versions.

Fix in Cursor Fix in Web

"fs-extra": "^10.0.0",
"http-graceful-shutdown": "^3.1.5",
"morgan": "^1.10.0",
"nocache": "^3.0.1"
},
"devDependencies": {
"rollup": "^1.14.6"
"rollup": "^4.59.0"
}
}
2 changes: 1 addition & 1 deletion packages/@pollyjs/persister-fs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,6 @@
"devDependencies": {
"fixturify": "^2.1.1",
"rimraf": "^3.0.2",
"rollup": "^1.14.6"
"rollup": "^2.80.0"
}
}
2 changes: 1 addition & 1 deletion packages/@pollyjs/persister-in-memory/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@
"@pollyjs/persister": "^6.0.5"
},
"devDependencies": {
"rollup": "^1.14.6"
"rollup": "^4.59.0"
}
}
2 changes: 1 addition & 1 deletion packages/@pollyjs/persister-local-storage/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@
"@pollyjs/persister": "^6.0.5"
},
"devDependencies": {
"rollup": "^1.14.6"
"rollup": "^4.59.0"
}
}
2 changes: 1 addition & 1 deletion packages/@pollyjs/persister-rest/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@
"@pollyjs/utils": "^6.0.1"
},
"devDependencies": {
"rollup": "^1.14.6"
"rollup": "^4.59.0"
}
}
2 changes: 1 addition & 1 deletion packages/@pollyjs/persister/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@
},
"devDependencies": {
"har-validator": "^5.1.5",
"rollup": "^1.14.6"
"rollup": "^4.59.0"
}
}
2 changes: 1 addition & 1 deletion packages/@pollyjs/utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@
"url-parse": "^1.5.3"
},
"devDependencies": {
"rollup": "^1.14.6"
"rollup": "^2.80.0"
}
}
Loading