Enable strict typing in Library/Homebrew/rubocops/

[dduugg]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

---

• AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

---

Gets us a bit closer to the finish line of #17297

[MikeMcQuaid]

Looks good when 🟢!

[Copilot]

Pull request overview

This PR moves the Library/Homebrew/rubocops/ code toward Sorbet # typed: strict, primarily by tightening type signatures, introducing T.let/casts where needed, and adjusting AST-argument access patterns to satisfy stricter nilability rules.

Changes:

• Switch multiple RuboCop cop/helper files to # typed: strict and add/update Sorbet sigs.
• Replace a number of .first/.last argument accesses with .fetch(...) and add casts to satisfy strict typing.
• Update/extend RBI/type definitions used by the RuboCop cask AST layer.

Reviewed changes

Copilot reviewed 26 out of 28 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
Library/Homebrew/sorbet/rbi/upstream.rbi	Updates temporary upstream RBI overrides (Integer <=> signature) and removes the prior IO patch.
Library/Homebrew/rubocops/version.rb	Uses fetch(0) for strict argument typing.
Library/Homebrew/rubocops/uses_from_macos.rb	Refactors first-argument handling for strict typing.
Library/Homebrew/rubocops/urls.rb	Uses fetch for strict argument typing in URL-related checks.
Library/Homebrew/rubocops/shared/url_helper.rb	Moves helper to typed: strict, adds sigs, adds casts/fetches.
Library/Homebrew/rubocops/shared/on_system_conditionals_helper.rb	Adjusts offensive node handling for strict typing.
Library/Homebrew/rubocops/shared/helper_functions.rb	Converts to typed: strict, adds many sigs, changes some return/collection behavior.
Library/Homebrew/rubocops/resource_requires_dependencies.rb	Adjusts offensive node handling for strict typing.
Library/Homebrew/rubocops/presence.rb	Converts to typed: strict and adds sigs for helper methods.
Library/Homebrew/rubocops/patches.rb	Uses fetch(0) for strict argument typing in patch URL extraction.
Library/Homebrew/rubocops/options.rb	Uses fetch(0) for strict argument typing.
Library/Homebrew/rubocops/livecheck.rb	Adds nil-guards and replaces .first with .fetch in some paths.
Library/Homebrew/rubocops/lines.rb	Broad set of strict-typing tweaks (fetches/casts/offensive node usage).
Library/Homebrew/rubocops/keg_only.rb	Converts to typed: strict and tightens nil handling for string indexing.
Library/Homebrew/rubocops/homepage.rb	Uses fetch(0) for strict argument typing.
Library/Homebrew/rubocops/extend/formula_cop.rb	Tightens audit_urls block typing and argument fetching/casting.
Library/Homebrew/rubocops/deprecate_disable.rb	Adjusts offensive node usage for strict typing.
Library/Homebrew/rubocops/dependency_order.rb	Converts to typed: strict, adds sigs, minor logic/style adjustments.
Library/Homebrew/rubocops/conflicts.rb	Tightens hash-node extraction and string indexing for strict typing.
Library/Homebrew/rubocops/components_order.rb	Adds initialize ivar declarations and more sigs/fetches.
Library/Homebrew/rubocops/cask/url.rb	Adjusts audit_url invocation to use the local stanza_node.
Library/Homebrew/rubocops/cask/stanza_order.rb	Converts to typed: strict and changes stanza sort implementation.
Library/Homebrew/rubocops/cask/stanza_grouping.rb	Converts to typed: strict, adds ivar typing and helper methods.
Library/Homebrew/rubocops/cask/extend/node.rbi	Adds an RBI definition for RuboCop::AST::BlockNode#method_node.
Library/Homebrew/rubocops/cask/ast/stanza.rb	Narrows stanza method_node types to specific AST node unions.
Library/Homebrew/rubocops/cask/ast/cask_header.rb	Converts to typed: strict and adds memoized helpers with sigs.
Library/Homebrew/rubocops/cask/array_alphabetization.rb	Converts to typed: strict and tightens nil handling in sorting logic.
Library/Homebrew/rubocops/bottle.rb	Adds a cast to align cellar_node typing with first_argument usage.

Files not reviewed (2)

• Library/Homebrew/rubocops/cask/extend/node.rbi: Language not supported
• Library/Homebrew/sorbet/rbi/upstream.rbi: Language not supported

Comments suppressed due to low confidence (1)

Library/Homebrew/rubocops/dependency_order.rb:96

• Minor style issue: if idx1 &&idx2 is missing a space after &&. This will likely violate the project's RuboCop spacing rules and reduce readability; consider idx1 && idx2.

            end
            insert_after!(ordered, idx1, idx2 + idx1) if idx1 &&idx2
          end

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[MikeMcQuaid]

Seems fine if 🟢, thanks!