fix: skip draft/pre-release versions in update banner check (#2254)

[idling11]

Summary

Version-check background task now ignores draft and pre-release
GitHub releases so a pushed tag does not trigger a premature
"vX.Y.Z available" banner before release assets are uploaded.

Closes: #2254

Problem

/releases/latest GitHub API returns the most recent release
including drafts and pre-releases. When a maintainer pushes a tag
(but hasn't uploaded binary assets yet), the status bar shows
a persistent "new version available" message that:

1. Is premature — the release isn't actually ready to download
2. Cannot be dismissed — permanently overrides user-configured
   statusline items

Fix

After fetching the release JSON, check draft and prerelease
fields. If either is true, return None so no hint is shown.

Files Changed

File	Change
crates/tui/src/tui/ui.rs	+8 lines

Greptile Summary

Adds a guard in the background version-check task that skips GitHub releases where draft or prerelease is true, preventing a premature "new version available" banner before release assets are ready.

• The fix correctly reads both fields from the GitHub API response and returns None (no banner) when either flag is set.
• The fallback defaults are asymmetric: draft uses unwrap_or(true) (treat missing as draft → always skip) while prerelease uses unwrap_or(false) (treat missing as stable → don't skip). This inconsistency means an absent or non-boolean draft field would permanently silence all update notifications.

Confidence Score: 4/5

The change is safe to merge — it tightens the update-notification filter and cannot break any other functionality.

The logic is sound and the GitHub API reliably returns these fields, so the asymmetric defaults are unlikely to cause problems in practice. However, unwrap_or(true) on draft silently suppresses all update banners any time the field is missing, while unwrap_or(false) on prerelease takes the opposite stance.

Only crates/tui/src/tui/ui.rs is affected; the inconsistent fallback defaults in the new guard are the only item worth a second look.

Important Files Changed

Filename	Overview
crates/tui/src/tui/ui.rs	Adds draft/pre-release guard in the version-check background task; the draft field's fallback default is inconsistent with prerelease's, risking silent suppression of all update notifications if the field is absent.

_{Reviews (1): Last reviewed commit: "fix: skip draft/prerelease versions in u..." | Re-trigger Greptile}

Greptile also left 1 inline comment on this PR.

[gemini-code-assist]

Code Review

This pull request adds a check to skip draft and pre-release versions when checking for new updates in the TUI. However, the reviewer pointed out that the GitHub API /releases/latest endpoint already excludes drafts and pre-releases, making this check redundant. The reviewer suggested either updating the CI/CD workflow to publish the release only after assets are uploaded, or checking if the assets array is empty in the client-side code.

[gemini-code-assist]

The GitHub API endpoint /releases/latest is documented to explicitly exclude both draft and pre-release versions (it only returns the most recent non-draft, non-prerelease release). Because of this, a successful response from this endpoint will never have draft: true or prerelease: true, making this check redundant.

If the premature banner is currently being triggered when a tag is pushed, it is likely because the CI/CD workflow immediately publishes the release as a full, non-draft release before the assets are fully uploaded. In that scenario, draft and prerelease will both be false, meaning this check will not prevent the premature banner.

To resolve this issue effectively, you can either:

1. Recommended: Update the CI/CD workflow to create the release as a draft first, upload the assets, and only publish it (set draft to false) once all assets are uploaded. Since /releases/latest already ignores drafts, this requires no client-side changes.
2. Client-side fallback: Check if the assets array in the JSON response is empty. If no assets are uploaded yet, we can skip showing the banner.

            if json["assets"].as_array().map_or(true, |a| a.is_empty()) {
                return None;
            }

[greptile-apps]

The fallback defaults for the two fields are inconsistent. draft uses unwrap_or(true) — treating a missing/non-bool value as "yes, it's a draft" (skip the banner) — while prerelease uses unwrap_or(false) — treating missing as "no, it's not a pre-release" (don't skip). If the draft key is ever absent from the response, all update notifications will be silently suppressed forever. Both fields should use the same default.

Suggested change

	if json["draft"].as_bool().unwrap_or(true)
	|| json["prerelease"].as_bool().unwrap_or(false)
	{
	if json["draft"].as_bool().unwrap_or(false)
	|| json["prerelease"].as_bool().unwrap_or(false)
	{

[Hmbown]

Reviewed the diff and CI. This is a narrow fix for #2254: draft/prerelease releases no longer trigger the update banner before assets are ready. Good for v0.8.48.

[Hmbown]

Thanks @idling11. I folded the draft/prerelease guard from this PR into #2275, which also requires the release assets plus checksum manifest to be uploaded and makes the update hint a transient status toast instead of a persistent footer override.

I added explicit credit for #2268 in #2275 so the contribution is carried into the v0.8.48 release notes/credit pass if that path lands. Leaving this open until #2275 finishes CI, then we can close/supersede this one without losing the attribution.

[Hmbown]

Closing this as superseded by #2275 now that the replacement PR is green. Your draft/prerelease guard is credited there, and #2275 carries the broader asset-readiness plus transient-toast behavior needed for #2254. Thanks again @idling11.