Merged
Conversation
- Add check-trigger job to prevent infinite loop from bot commits - Add git pull step to ensure Job 2 gets latest version after bump - Read version from file in Job 2 instead of relying on Job 1 outputs - Fix YAML indentation in PR comment template literal - Add proper job dependencies and conditions
fix(ci): improve release PR check workflow
Abdallah-khalil
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
View your CI Pipeline Execution ↗ for commit 02a523a
☁️ Nx Cloud last updated this comment at |
Abdallah-khalil
temporarily deployed
to
github-pages
GitHub Actions
Inactive
BREAKING CHANGE: Complete overhaul of release workflow - Remove release-pr-check.yml (manual version bump workflow) - Remove publish-on-branch.yml (branch-based release) - Add release-please.yml (Google's Release Please for automated releases) - Add release-please-config.json (monorepo configuration) - Add .release-please-manifest.json (version tracking) - Update publish.yml header (now emergency-only) - Update docs/publishing/README.md with new workflow New workflow: 1. Use conventional commits with scope (feat(angular-3d): ...) 2. Release Please auto-creates Release PRs 3. Merge Release PR to publish to npm Benefits: - No manual version bumping required - No branch protection conflicts - Automatic CHANGELOG generation - Industry-standard approach used by Angular, Firebase, etc.
feat(ci): replace custom release workflow with Release Please
Abdallah-khalil
temporarily deployed
to
github-pages
GitHub Actions
Inactive
- CI now only runs on pull requests (not on main push) - Disable deploy-gh-pages automatic trigger (manual only for now) - Update release-please workflow settings This prevents duplicate workflow runs when PRs are merged.
chore(ci): optimize workflow triggers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief description of changes.
Type of Change
Related Issue
Fixes #(issue number)
Library Affected
Checklist
npx nx run-many -t lint test typecheck buildlocallyScreenshots (if applicable)
Breaking Changes (if applicable)