Skip to content

fix(ci): improve release PR check workflow#19

Merged
Abdallah-khalil merged 1 commit intomainfrom
fix/release-pr-check-workflow
Jan 20, 2026
Merged

fix(ci): improve release PR check workflow#19
Abdallah-khalil merged 1 commit intomainfrom
fix/release-pr-check-workflow

Conversation

@Abdallah-khalil
Copy link
Copy Markdown
Collaborator

  • Add check-trigger job to prevent infinite loop from bot commits
  • Add git pull step to ensure Job 2 gets latest version after bump
  • Read version from file in Job 2 instead of relying on Job 1 outputs
  • Fix YAML indentation in PR comment template literal
  • Add proper job dependencies and conditions

Description

Brief description of changes.

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • Performance improvement
  • Test update

Related Issue

Fixes #(issue number)

Library Affected

  • @hive-academy/angular-3d
  • @hive-academy/angular-gsap
  • Demo app
  • Documentation only

Checklist

  • My code follows the project's coding standards
  • I have run npx nx run-many -t lint test typecheck build locally
  • I have added tests covering my changes
  • All new and existing tests pass
  • I have updated relevant documentation
  • My commits follow conventional commit format

Screenshots (if applicable)

Breaking Changes (if applicable)

- Add check-trigger job to prevent infinite loop from bot commits
- Add git pull step to ensure Job 2 gets latest version after bump
- Read version from file in Job 2 instead of relying on Job 1 outputs
- Fix YAML indentation in PR comment template literal
- Add proper job dependencies and conditions
@Abdallah-khalil Abdallah-khalil merged commit 1045eca into main Jan 20, 2026
2 checks passed
@Abdallah-khalil Abdallah-khalil deleted the fix/release-pr-check-workflow branch January 20, 2026 08:46
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Jan 20, 2026

View your CI Pipeline Execution ↗ for commit 0cdf796

Command Status Duration Result
nx run-many -t lint test typecheck build ✅ Succeeded 9s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-20 08:47:51 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant