Use RTSoA Particle Container#1234
Open
AlexanderSinn wants to merge 23 commits intoHi-PACE:developmentfrom
Open
Use RTSoA Particle Container#1234AlexanderSinn wants to merge 23 commits intoHi-PACE:developmentfrom
AlexanderSinn wants to merge 23 commits intoHi-PACE:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the particle containers for both Beams and Plasmas with the new
amrex::ParticleTileRT/amrex::ParticleContainerRTSoA. These only have runtime components, which will let us allocate particle components much more dynamically, just like the fields.Now that beam and plasma tiles have the same data type, this potentially allows reusing functions more easily between the two.
The performance seems to be very similar to development, maybe <1% slower for some runs. Only the particle sorting/reordering is significantly slower because the vectors cannot be swapped anymore and need to be copied back.
constisconst)