test(observability): cover console-metrics, batch, reqlog & readiness branches#201
Open
mauripunzueta wants to merge 1 commit into
Open
test(observability): cover console-metrics, batch, reqlog & readiness branches#201mauripunzueta wants to merge 1 commit into
mauripunzueta wants to merge 1 commit into
Conversation
90e3aca to
cddea94
Compare
…branches Add tests for the genuinely-uncovered behavioral branches surfaced by the PR #150 Codecov report (as opposed to stale-carryforward lines, which a fresh coverage run clears, or error-handling closures, which need SQL fault injection): - reqlog: 3xx / 4xx / sub-200 status-class classification arms (existing tests exercised only 2xx and 5xx) - console resource-distribution: the `other` roll-up bucket taken when the number of distinct types exceeds `top` - console tenants: a tenant present only in the request-log traffic, with no stored resources (reported as `resources: 0`) - batch: exhaustive TransactionError -> (status, code) mapping and the status_text reason-phrase table - health: the /_readiness handler response shape Adds helios-observability as a dev-dependency of helios-rest so the console integration test can seed the in-process request log directly (the test router has no request-tracking middleware).
e33438a to
3f1203f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #150 (
feat/observability-uptime). Adds tests for the genuinely-uncovered behavioral branches that PR #150's Codecov report flagged.Context
Most of PR #150's reported patch-coverage gap is not new-test-addressable:
.map_err(|e| internal_error(...))on SQL failures) — unreachable without fault injection;This PR covers the branches that were actually uncovered and cheaply testable.
Tests added
otherroll-up bucket taken when distinct types exceedtop.resources: 0).TransactionError -> (status, code)mapping and thestatus_textreason-phrase table./_readinesshandler response shape.Adds
helios-observabilityas a dev-dependency ofhelios-restso the console integration test can seed the in-process request log directly (the test router has no request-tracking middleware).CI note
Because the repo gates
pull_requestCI tobase: main, this stacked PR (basefeat/observability-uptime) will not run CI/Codecov until #150 merges and GitHub auto-retargets it tomain.