Fix errors on the Comp constructor taking the entire class as pos - #76
Open
Speedphoenix wants to merge 1 commit into
Open
Fix errors on the Comp constructor taking the entire class as pos#76Speedphoenix wants to merge 1 commit into
Speedphoenix wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment this code yields the error
h2d.Object should be Null<Float> For function argument 'parent', but highlights the error on the entire class.This PR makes it so it only takes the pos of the constructor
The actual error is located in the runtime component generated code that does
new ClassB(cast args[0], parent);because there's a wrong type inference on the constructor arguments. Usingnullon super's optional arguments or explicitly typingparentfixes the error.