added string interpolation support#163
Open
Davvex87 wants to merge 5 commits intoHaxeFoundation:masterfrom
Open
added string interpolation support#163Davvex87 wants to merge 5 commits intoHaxeFoundation:masterfrom
Davvex87 wants to merge 5 commits intoHaxeFoundation:masterfrom
Conversation
auto add a "shadow semicolon" at the end of the interpolated block if one is missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yes, I'm aware that #62 exists, however, that PR had some bugs, was missing features (notably interpolation with block expressions), and appears to have been abandoned, so I've opened this PR to properly implement string interpolation in hscript to replicate the original behavior as closely as possible.
Don't get me wrong, @DleanJeans did a great job with the initial implementation; it just had a few quirks I wanted to fix. My intention was never to overshadow the original work.
(Also fixes #61)