Refactor: Modernize C++ code in FsColorMatKey#42
Draft
google-labs-jules[bot] wants to merge 1 commit intomainfrom
Draft
Refactor: Modernize C++ code in FsColorMatKey#42google-labs-jules[bot] wants to merge 1 commit intomainfrom
google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
This commit refactors the C++ source and header files in the `Source/Effects/FsColorMatKey` directory. The changes include: - Removing unnecessary comments. - Translating Japanese comments to English. - Replacing old include guards with `#pragma once`. - Protecting include order with `clang-format` guards. - Applying `clang-format` for consistent styling. The files `ColorMatKeySub8.cpp` and `Fs_Entry.h` were skipped due to missing external dependencies that caused validation failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch refactors the C++ source and header files in the
Source/Effects/FsColorMatKeydirectory to align with modern C++ practices and improve code clarity.The following changes were made to the files in the target directory:
#ifndef/#define/#endifinclude guards with the more modern#pragma oncedirective in header files.#includeblocks with// clang-format offand// clang-format onto protect the include order from being changed by formatters.clang-formatto the modified files to ensure consistent code styling.The following files were successfully refactored:
ColorMatKey.hColorMatKey.cppFs_Target.hThe following files were intentionally skipped due to unresolved external dependencies (
GInfoandParamInfo8structs) that prevented the code from being validated and safely modified:ColorMatKeySub8.cppFs_Entry.hAdditionally, the
.clang-format-ignorefile was updated to allow formatting of the target directory.